HDDS-1895. Support Key ACL operations for OM HA. #1230

bharatviswa504 · 2019-08-05T23:06:12Z

This patch is dependent on HDDS-1884.
Posted this PR on top of HDDS-1884.
2nd commit is the actual changes for this PR.

hadoop-yetus · 2019-08-06T01:16:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	584	trunk passed
+1	compile	373	trunk passed
+1	checkstyle	77	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	873	branch has no errors when building and testing our client artifacts.
+1	javadoc	161	trunk passed
0	spotbugs	413	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	606	trunk passed
		_ Patch Compile Tests _
0	mvndep	23	Maven dependency ordering for patch
+1	mvninstall	559	the patch passed
+1	compile	389	the patch passed
+1	cc	389	the patch passed
+1	javac	389	the patch passed
-0	checkstyle	50	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	680	patch has no errors when building and testing our client artifacts.
+1	javadoc	159	the patch passed
+1	findbugs	633	the patch passed
		_ Other Tests _
+1	unit	282	hadoop-hdds in the patch passed.
-1	unit	1972	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		7739

Reason	Tests
Failed junit tests	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/1/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux c2829efda7ee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d6697da`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/1/testReport/
Max. process+thread count	4999 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T02:12:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	32	Maven dependency ordering for branch
+1	mvninstall	590	trunk passed
+1	compile	372	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	811	branch has no errors when building and testing our client artifacts.
+1	javadoc	148	trunk passed
0	spotbugs	428	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	619	trunk passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
+1	mvninstall	576	the patch passed
+1	compile	387	the patch passed
+1	cc	387	the patch passed
+1	javac	387	the patch passed
-0	checkstyle	33	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	644	patch has no errors when building and testing our client artifacts.
+1	javadoc	158	the patch passed
+1	findbugs	688	the patch passed
		_ Other Tests _
-1	unit	198	hadoop-hdds in the patch failed.
-1	unit	2772	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		8368

Reason	Tests
Failed junit tests	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux dc1375ba6c49 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3cc0ace`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/testReport/
Max. process+thread count	3635 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T10:20:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	54	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	618	trunk passed
+1	compile	366	trunk passed
+1	checkstyle	77	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	843	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	449	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	653	trunk passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	555	the patch passed
+1	compile	373	the patch passed
+1	cc	373	the patch passed
+1	javac	373	the patch passed
-0	checkstyle	38	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	650	patch has no errors when building and testing our client artifacts.
+1	javadoc	146	the patch passed
+1	findbugs	618	the patch passed
		_ Other Tests _
-1	unit	302	hadoop-hdds in the patch failed.
-1	unit	2210	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7888

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.om.TestKeyManagerImpl
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 8fdb94c2cae7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `00b5a27`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/testReport/
Max. process+thread count	4470 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

(cherry picked from commit 34b13cf816cac0fd321c2be37d36d0b17c283d53)

bharatviswa504 · 2019-08-09T05:57:50Z

Rebased on top of the latest trunk, as HDDS-1884 got checked in.
Now it is ready for review.

bharatviswa504 · 2019-08-09T05:57:56Z

/retest

hadoop-yetus · 2019-08-09T08:04:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	33	Maven dependency ordering for branch
+1	mvninstall	597	trunk passed
+1	compile	373	trunk passed
+1	checkstyle	76	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	870	branch has no errors when building and testing our client artifacts.
+1	javadoc	164	trunk passed
0	spotbugs	420	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	617	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	561	the patch passed
+1	compile	374	the patch passed
+1	javac	374	the patch passed
+1	checkstyle	85	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	690	patch has no errors when building and testing our client artifacts.
+1	javadoc	161	the patch passed
+1	findbugs	632	the patch passed
		_ Other Tests _
+1	unit	395	hadoop-hdds in the patch passed.
-1	unit	1727	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		7652

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.om.TestKeyManagerImpl

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/4/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c5e8fb518c6a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `88ed1e0`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/4/testReport/
Max. process+thread count	5001 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

...one-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java

...one-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAddAclRequest.java

bharatviswa504 · 2019-08-09T21:58:00Z

Thank You @arp7 for the offline discussion.
Addressed the review comments.

bharatviswa504 · 2019-08-09T21:58:07Z

/retest

hadoop-yetus · 2019-08-10T00:05:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	16	Maven dependency ordering for branch
+1	mvninstall	598	trunk passed
+1	compile	374	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	867	branch has no errors when building and testing our client artifacts.
+1	javadoc	166	trunk passed
0	spotbugs	423	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	619	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	567	the patch passed
+1	compile	380	the patch passed
+1	javac	380	the patch passed
+1	checkstyle	82	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	681	patch has no errors when building and testing our client artifacts.
+1	javadoc	172	the patch passed
+1	findbugs	641	the patch passed
		_ Other Tests _
+1	unit	297	hadoop-hdds in the patch passed.
-1	unit	1764	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		7608

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.om.TestKeyManagerImpl

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/5/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 11ed57c004ba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `98dd7c4`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/5/testReport/
Max. process+thread count	5365 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-10T00:53:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	82	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	38	Maven dependency ordering for branch
+1	mvninstall	624	trunk passed
+1	compile	378	trunk passed
+1	checkstyle	75	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	963	branch has no errors when building and testing our client artifacts.
+1	javadoc	173	trunk passed
0	spotbugs	466	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	684	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	583	the patch passed
+1	compile	478	the patch passed
+1	javac	478	the patch passed
+1	checkstyle	92	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	888	patch has no errors when building and testing our client artifacts.
+1	javadoc	215	the patch passed
+1	findbugs	770	the patch passed
		_ Other Tests _
+1	unit	421	hadoop-hdds in the patch passed.
-1	unit	3537	hadoop-ozone in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		10264

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.scm.TestSCMNodeManagerMXBean
	hadoop.ozone.scm.TestSCMMXBean
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.client.rpc.TestKeyInputStream

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/6/artifact/out/Dockerfile
GITHUB PR	#1230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ab345089517b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `98dd7c4`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/6/testReport/
Max. process+thread count	3462 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1230/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

arp7

+1 pending CI. Thanks @bharatviswa504 !

arp7 · 2019-08-10T03:33:02Z

I committed this. None of the test failures looks related.

cawatson · 2019-08-21T13:53:04Z

I am creating a tool to aid developers by partially automating unit testing.
Could you speak to the validity of these generated assert statement for the given test method?
All test methods come from the file: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java

Test Method: testAllBucketOperations
Assert Statement(s):
org . junit . Assert . assertTrue ( versioning . getVersioning ( ) )
org . junit . Assert . assertTrue ( OzoneTestUtils . getVersioning ( ) )
org . junit . Assert . assertTrue ( OzoneBucket . getVersioning ( ) )

Test Method: testFileOperationsWithNonRecursive
Assert Statement(s):
org . junit . Assert . assertNotNull ( OMException )
org . junit . Assert . assertNotNull ( keyName )

Test Method: testMultipartUploadWithOneOmNodeDown
Assert Statement(s):
org . junit . Assert . assertNotNull ( keyName )
org . junit . Assert . assertTrue ( objectStore . getOMProxyProvider ( node ) )

Test Method: testOMProxyProviderFailoverToCurrentLeader
Assert Statement(s):
org . junit . Assert . assertTrue ( ( ( leaderOMNodeId . createVolumeTest ( node ) ) == 1 ) )
org . junit . Assert . assertTrue ( ( ( leaderOMNodeId . createVolumeTest ( node ) ) == 0 ) )
org . junit . Assert . assertTrue ( ( ( leaderOMNodeId . createVolumeTest ( node ) ) > 0 ) )

Test Method: testOMRetryProxy
Assert Statement(s):
org . junit . Assert . assertTrue ( ( ( Logger . addAppender ( node ) ) == null ) )

Test Method: testReadRequest
Assert Statement(s):
org . junit . Assert . assertEquals ( 0 , currentLeaderNodeId . count ( 10 ) )

Thank you for your time.

bharatviswa504 requested review from arp7 and xiaoyuyao August 5, 2019 23:06

bharatviswa504 added the ozone label Aug 5, 2019

bharatviswa504 self-assigned this Aug 5, 2019

HDDS-1895. Support Key ACL operations for OM HA.

f2fe6d2

(cherry picked from commit 34b13cf816cac0fd321c2be37d36d0b17c283d53)

bharatviswa504 force-pushed the HDDS-1895 branch from 34b13cf to f2fe6d2 Compare August 9, 2019 05:55

arp7 reviewed Aug 9, 2019

View reviewed changes

...one-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java Outdated Show resolved Hide resolved

arp7 reviewed Aug 9, 2019

View reviewed changes

...one-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAddAclRequest.java Outdated Show resolved Hide resolved

arp7 reviewed Aug 9, 2019

View reviewed changes

...one-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAddAclRequest.java Outdated Show resolved Hide resolved

bharatviswa504 added 2 commits August 9, 2019 14:49

address review comments.

a4ba0cf

remove some not needed methods.

1bba0eb

javadoc update.

95c1f79

arp7 approved these changes Aug 10, 2019

View reviewed changes

arp7 merged commit bd4be6e into apache:trunk Aug 10, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1895. Support Key ACL operations for OM HA. (apache#1230)

1572d8c

HDDS-1895. Support Key ACL operations for OM HA. #1230

HDDS-1895. Support Key ACL operations for OM HA. #1230

Uh oh!

Conversation

bharatviswa504 commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Aug 6, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

bharatviswa504 commented Aug 9, 2019

Uh oh!

bharatviswa504 commented Aug 9, 2019

Uh oh!

hadoop-yetus commented Aug 9, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bharatviswa504 commented Aug 9, 2019

Uh oh!

bharatviswa504 commented Aug 9, 2019

Uh oh!

hadoop-yetus commented Aug 10, 2019

Uh oh!

hadoop-yetus commented Aug 10, 2019

Uh oh!

arp7 left a comment

Choose a reason for hiding this comment

Uh oh!

arp7 commented Aug 10, 2019

Uh oh!

cawatson commented Aug 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bharatviswa504 commented Aug 5, 2019 •

edited

Loading