Skip to content

Conversation

@xiaoyuyao
Copy link
Contributor

…ontributed by Xiaoyu Yao.

@xiaoyuyao xiaoyuyao self-assigned this Aug 9, 2019
@xiaoyuyao xiaoyuyao added the ozone label Aug 9, 2019
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @xiaoyuyao.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 598 trunk passed
+1 compile 364 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 936 branch has no errors when building and testing our client artifacts.
+1 javadoc 165 trunk passed
0 spotbugs 429 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 625 trunk passed
_ Patch Compile Tests _
+1 mvninstall 544 the patch passed
+1 compile 367 the patch passed
+1 javac 367 the patch passed
+1 checkstyle 75 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 729 patch has no errors when building and testing our client artifacts.
+1 javadoc 163 the patch passed
+1 findbugs 647 the patch passed
_ Other Tests _
+1 unit 328 hadoop-hdds in the patch passed.
-1 unit 1700 hadoop-ozone in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
7556
Reason Tests
Failed junit tests hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1262/1/artifact/out/Dockerfile
GITHUB PR #1262
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a0f965019c36 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6ff0453
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1262/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1262/1/testReport/
Max. process+thread count 4475 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1262/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Thank You @xiaoyuyao for the fix.

@xiaoyuyao
Copy link
Contributor Author

Thanks @bharatviswa504 and @adoroszlai for the review. I will merge this to trunk shortly.

@xiaoyuyao xiaoyuyao merged commit fba222a into apache:trunk Aug 10, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants