-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-2037. Fix hadoop version in pom.ozone.xml. #1351
Conversation
@@ -100,10 +100,6 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
<groupId>org.bouncycastle</groupId> | |||
<artifactId>bcprov-jdk15on</artifactId> | |||
</dependency> | |||
<dependency> | |||
<groupId>io.dropwizard.metrics</groupId> | |||
<artifactId>metrics-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nandakumar131 for fixing these Maven warnings, too.
@elek are there any known issues if we depend on 3.1.0? like the OzoneFS ? |
@anuengineer Until now all the testing is done with hadoop 3.2.0 and also the previous ozone release (0.4.0-alpha) was done with hadoop 3.2.0 as dependency. |
💔 -1 overall
This message was automatically generated. |
I think we already started to use 3.2 specific APIs. Some of our requirements are included in hadoop 3.2 but not in 3.1. If we need any fixes in the hadoop common we should wait until hadoop 3.3. Using 3.1 it would be even harder. I would use 3.2 as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks @nandakumar131 for the fix.
I think we can commit this and continue the discussion about 3.2 vs 3.1.
@@ -65,7 +65,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs | |||
|
|||
<properties> | |||
<!-- required as child projects with different version can't use ${project.version} --> | |||
<hadoop.version>3.3.0-SNAPSHOT</hadoop.version> | |||
<hadoop.version>3.2.0</hadoop.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line can be even deleted AFAIK. There is no project which has this pom.ozone.xml as the parent. Therefore this hadoop.version property is not used at all. (but not a problem to keep it).
No description provided.