HDDS-2014. Create Symmetric Key for GDPR #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/label ozone |
Enforce secret length using Preconditions.
Contributor
Author
|
/retest |
Contributor
Author
|
Addressed review comment from @anuengineer to avoid padding and instead enforce the secret length. |
Contributor
Author
|
Failures unrelated to patch |
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/GDPRSymmetricKey.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/GDPRSymmetricKey.java
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/GDPRSymmetricKey.java
Show resolved
Hide resolved
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
Posted a few comments in place.
Contributor
|
+1 LGTM. Pending CI. |
Contributor
Author
|
failures unrelated to patch |
Contributor
|
Thank You @dineshchitlangia for the contribution. |
Contributor
|
@bharatviswa504 Thanks for the reviews. @dineshchitlangia Thank you for the contribution. I have committed this to the trunk. |
Contributor
Author
|
Thank you @bharatviswa504 and @anuengineer |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.