HDDS-2210. ContainerStateMachine should not be marked unhealthy if ap… #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plyTransaction fails with closed container exception.
| @@ -270,12 +270,16 @@ public void persistContainerSet(OutputStream out) throws IOException { | |||
| // container happens outside of Ratis. | |||
| IOUtils.write(builder.build().toByteArray(), out); | |||
| } | |||
|
|
|||
|
💔 -1 overall
This message was automatically generated. |
mukul1987
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks for working on this @bshashikant, the patch looks good to me. Can you please take care of some of the minor checkstyle issues ?
| @@ -759,7 +767,7 @@ public void notifyIndexUpdate(long term, long index) { | |||
| // add the entry to the applyTransactionCompletionMap only if the | |||
| // stateMachine is healthy i.e, there has been no applyTransaction | |||
| // failures before. | |||
| if (isStateMachineHealthy.get()) { | |||
| if (stateMachineHealthy.get()) { | |||
There was a problem hiding this comment.
lets replace this with isStateMachineHealthy
hadoop-yetus
reviewed
Oct 1, 2019
| @@ -270,12 +270,16 @@ public void persistContainerSet(OutputStream out) throws IOException { | |||
| // container happens outside of Ratis. | |||
| IOUtils.write(builder.build().toByteArray(), out); | |||
| } | |||
|
|
|||
|
💔 -1 overall
This message was automatically generated. |
mukul1987
approved these changes
Oct 1, 2019
|
💔 -1 overall
This message was automatically generated. |
fapifta
pushed a commit
to fapifta/hadoop
that referenced
this pull request
Oct 2, 2019
…plyTransaction fails with closed container exception(apache#1552).
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…plyTransaction fails with closed container exception(apache#1552).
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…plyTransaction fails with closed container exception(apache#1552).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plyTransaction fails with closed container exception.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute