Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16620. [pb-upgrade] Remove protocol buffers 3.7.1 from requirements in BUILDING.txt #1558

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Oct 1, 2019

@aajisaka aajisaka requested a review from vinayakumarb October 1, 2019 07:13
@vinayakumarb
Copy link
Contributor

Thanks @aajisaka .
I think you can also remove from DockerFile ?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 2290 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 shadedclient 857 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 844 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 asflicense 28 The patch does not generate ASF License warnings.
4126
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1558/1/artifact/out/Dockerfile
GITHUB PR #1558
Optional Tests dupname asflicense
uname Linux 011f6dcbb142 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 137546a
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: . U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1558/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

aajisaka commented Oct 2, 2019

@vinayakumarb Thank you for your review! Removed protoc from Dockerfile.

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-1558/2/console in case of problems.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 288 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 shadedclient 874 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 hadolint 3 There were no new hadolint issues.
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 847 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 asflicense 30 The patch does not generate ASF License warnings.
2161
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1558/2/artifact/out/Dockerfile
GITHUB PR #1558
Optional Tests dupname asflicense hadolint shellcheck shelldocs
uname Linux 728e06e685ce 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3df733c
Max. process+thread count 307 (vs. ulimit of 5500)
modules C: . U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1558/2/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aajisaka aajisaka merged commit 0e026cb into apache:trunk Oct 3, 2019
@aajisaka
Copy link
Member Author

aajisaka commented Oct 3, 2019

Merged. Thank you @vinayakumarb and @ayushtkn

@aajisaka aajisaka deleted the HADOOP-16620 branch October 3, 2019 06:25
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
…ments in BUILDING.txt (apache#1558)

* Removed protobuf 3.7.1 from Dockerfile
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
…ments in BUILDING.txt (apache#1558)

* Removed protobuf 3.7.1 from Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants