HDDS-2227. GDPR key generation could benefit from secureRandom.

[anuengineer]

https://issues.apache.org/jira/browse/HDDS-2227
The SecureRandom can be used for the symetric key for GDPR. While GDPR is not a security feature, this is a good to have optional feature.

I want to thank Jonathan Leitschuh, for originally noticing this issue and reporting it.

How tested: ran unit.sh, had one failure in TestSCMContainerPlacementRackAware

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	80	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	40	Maven dependency ordering for branch
-1	mvninstall	30	hadoop-hdds in trunk failed.
-1	mvninstall	35	hadoop-ozone in trunk failed.
-1	compile	18	hadoop-hdds in trunk failed.
-1	compile	13	hadoop-ozone in trunk failed.
+1	checkstyle	55	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	941	branch has no errors when building and testing our client artifacts.
-1	javadoc	19	hadoop-hdds in trunk failed.
-1	javadoc	16	hadoop-ozone in trunk failed.
0	spotbugs	1041	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	44	hadoop-hdds in trunk failed.
-1	findbugs	17	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
-1	mvninstall	32	hadoop-hdds in the patch failed.
-1	mvninstall	34	hadoop-ozone in the patch failed.
-1	compile	21	hadoop-hdds in the patch failed.
-1	compile	16	hadoop-ozone in the patch failed.
-1	javac	21	hadoop-hdds in the patch failed.
-1	javac	16	hadoop-ozone in the patch failed.
+1	checkstyle	52	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	780	patch has no errors when building and testing our client artifacts.
-1	javadoc	19	hadoop-hdds in the patch failed.
-1	javadoc	16	hadoop-ozone in the patch failed.
-1	findbugs	28	hadoop-hdds in the patch failed.
-1	findbugs	17	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	25	hadoop-hdds in the patch failed.
-1	unit	23	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		2541

Subsystem	Report/Notes
Docker	Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/Dockerfile
GITHUB PR	#1574
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux b7bcf0739860 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 41440ec
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/testReport/
Max. process+thread count	306 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/client U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1574/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[dineshchitlangia]

+1 LGTM, failures dont seem related to patch. Thanks Anu.

[anuengineer]

The failures are not related to this patch.

[anuengineer]

@dineshchitlangia Thank you for the review. I have committed this patch to the trunk.