HDDS-2222 Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C

[szetszwo]

See https://issues.apache.org/jira/browse/HDDS-2222

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
-1	mvninstall	31	hadoop-hdds in trunk failed.
-1	mvninstall	36	hadoop-ozone in trunk failed.
-1	compile	22	hadoop-hdds in trunk failed.
-1	compile	16	hadoop-ozone in trunk failed.
+1	checkstyle	56	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	960	branch has no errors when building and testing our client artifacts.
-1	javadoc	21	hadoop-hdds in trunk failed.
-1	javadoc	19	hadoop-ozone in trunk failed.
0	spotbugs	1055	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	30	hadoop-hdds in trunk failed.
-1	findbugs	21	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
-1	mvninstall	35	hadoop-hdds in the patch failed.
-1	mvninstall	37	hadoop-ozone in the patch failed.
-1	compile	26	hadoop-hdds in the patch failed.
-1	compile	18	hadoop-ozone in the patch failed.
-1	javac	26	hadoop-hdds in the patch failed.
-1	javac	18	hadoop-ozone in the patch failed.
-0	checkstyle	28	hadoop-hdds: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	749	patch has no errors when building and testing our client artifacts.
-1	javadoc	21	hadoop-hdds in the patch failed.
-1	javadoc	18	hadoop-ozone in the patch failed.
-1	findbugs	32	hadoop-hdds in the patch failed.
-1	findbugs	19	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	28	hadoop-hdds in the patch failed.
-1	unit	26	hadoop-ozone in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		2479

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/Dockerfile
GITHUB PR	#1578
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d12771a51d3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b09d389
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common U: hadoop-hdds/common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1578/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[jnp]

+1 for the patch

[jnp]

+1 for the patch.

[szetszwo]

The checkstyle warnings in ChecksumByteBuffer are absurd so that we will ignore them.

[szetszwo]

The "Switch case falls through" reported by findbugs is by design so that we won't fix it.

[szetszwo]

The integration failures definitely are not related since the new code is not yet used in Ozone.

[szetszwo]

The "Switch case falls through" reported by findbugs is by design so that we won't fix it.

Oops, I should have added it to findbugsExcludeFile.xml. Otherwise, the warning will keep coming up. Will revert the commit