Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2251. Add an option to customize unit.sh and integration.sh parameters #1598

Closed
wants to merge 1 commit into from

Conversation

elek
Copy link
Member

@elek elek commented Oct 4, 2019

hadoop-ozone/dev-support/checks/unit.sh (and same with integration) provides an easy entrypoint to execute all the unit/integration test. But in same cases it would be great to use the script but further specify the scope of the test.

With this simple patch it will be possible to adjust the surefire parameters.

See: https://issues.apache.org/jira/browse/HDDS-2251

@elek elek added the ozone label Oct 4, 2019
Copy link
Contributor

@swagle swagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. Thanks for improving this @elek .

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 84 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 32 hadoop-hdds in trunk failed.
-1 mvninstall 33 hadoop-ozone in trunk failed.
+1 mvnsite 0 trunk passed
+1 shadedclient 895 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 mvninstall 38 hadoop-hdds in the patch failed.
-1 mvninstall 43 hadoop-ozone in the patch failed.
+1 mvnsite 0 the patch passed
+1 shellcheck 1 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 846 patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 unit 26 hadoop-hdds in the patch failed.
-1 unit 25 hadoop-ozone in the patch failed.
+1 asflicense 31 The patch does not generate ASF License warnings.
2193
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/Dockerfile
GITHUB PR #1598
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux 2f550eed1242 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3f16651
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-ozone U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1598/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@elek
Copy link
Member Author

elek commented Oct 5, 2019

Thanks @dineshchitlangia and @swagle the review. I am merging it to the trunk right now...

@elek elek closed this in 579dc87 Oct 5, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants