HDFS-15329. Provide FileContext based ViewFSOverloadScheme implementation #2225
+569
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
abhishekdas99
force-pushed
the
HDFS-15329
branch
2 times, most recently
from
dddd30e to
52289f0
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| /** | ||
| * Sets up the configurations and starts the MiniDFSCluster. | ||
| */ | ||
| @Before |
There was a problem hiding this comment.
I remember I made this tests to starts cluster only once. That will improve tests time, You may want to have a look at corresponding ViewFileSystemOverloadScheme test class now.
| import org.junit.Test;; | ||
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
ViewFileSystemOverloadScheme --> ViewFsOverloadScheme
| // TODO: Should we fail here.? | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug( | ||
| "Missing configuration for fs.viewfs.mounttable.path. Proceeding" |
There was a problem hiding this comment.
avaialable -> available. ( Its might be my mistake, same typo may be there in Original class as well :-) )
There was a problem hiding this comment.
Fixed. Also changed ViewFileSystemOverloadScheme.java
abhishekdas99
force-pushed
the
HDFS-15329
branch
3 times, most recently
from
ba64b51 to
27777c2
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The latest patch looks good to me. There is one findbug popped up. Could you please take a look at it. Otherwise I am +1 |
…tion ViewFsOverloadScheme is extended from the ViewFs for the overloaded scheme file system. To use this class, the following configurations need to be added in core-site.xml file. 1) fs.AbstractFileSystem.<scheme>.impl = org.apache.hadoop.fs.viewfs.ViewFsOverloadScheme and 2) fs.viewfs.overload.scheme.target.abstract.<scheme>.impl = "<hadoop compatible file system implementation class name for the <scheme>"
abhishekdas99
force-pushed
the
HDFS-15329
branch
from
27777c2 to
c54d8c9
Compare
The findbug issue is not part of the new change. I have fixed the issue. |
|
💔 -1 overall
This message was automatically generated. |
|
There was a compilation error. Please check. (I triggered a rebuild to make sure it's not infra related) |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15329