HADOOP-17422. ABFS: Set default ListMaxResults to max server limit #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
TEST RESULTS HNS Account Location: East US 2 |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
TEST RESULTS HNS Account Location: East US 2 |
|
🎊 +1 overall
This message was automatically generated. |
bilaharith
reviewed
Dec 10, 2020
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.Future; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; |
Contributor
There was a problem hiding this comment.
import order,
java
non java
apache
bilaharith
reviewed
Dec 10, 2020
| public void testListPath() throws Exception { | ||
| final AzureBlobFileSystem fs = getFileSystem(); | ||
| Configuration config = new Configuration(this.getRawConfiguration()); | ||
| config.set("fs.azure.list.max.results", "5000"); |
Contributor
There was a problem hiding this comment.
Is there tests with fs.azure.list.max.results with different values and asserting on the number of items returned.
Contributor
Author
There was a problem hiding this comment.
Replaced with const
Yes, test in ITestAbfsClient asserts return size for liststatus calls with different values of listMaxResults (set at AbfsConfig level)
bilaharith
suggested changes
Dec 10, 2020
Contributor
bilaharith
left a comment
bilaharith
left a comment
There was a problem hiding this comment.
Please check the comments
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bilaharith
approved these changes
Dec 14, 2020
asfgit
pushed a commit
that referenced
this pull request
Dec 21, 2020
…2535) Contributed by Sumangala Patki TEST RESULTS: namespace.enabled=true auth.type=SharedKey ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 24 Tests run: 208, Failures: 0, Errors: 0, Skipped: 24 namespace.enabled=true auth.type=OAuth ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 70 Tests run: 208, Failures: 0, Errors: 0, Skipped: 141
ThomasMarquardt
approved these changes
Dec 21, 2020
Contributor
|
commit a35fc38 |
sumangala-patki
pushed a commit
to sumangala17/hadoop
that referenced
this pull request
Jan 13, 2021
…pache#2535) Contributed by Sumangala Patki TEST RESULTS: namespace.enabled=true auth.type=SharedKey ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 24 Tests run: 208, Failures: 0, Errors: 0, Skipped: 24 namespace.enabled=true auth.type=OAuth ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 70 Tests run: 208, Failures: 0, Errors: 0, Skipped: 141 (cherry picked from commit a35fc38)
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2021
…2535) Contributed by Sumangala Patki TEST RESULTS: namespace.enabled=true auth.type=SharedKey ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 24 Tests run: 208, Failures: 0, Errors: 0, Skipped: 24 namespace.enabled=true auth.type=OAuth ------------------- $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify Tests run: 90, Failures: 0, Errors: 0, Skipped: 0 Tests run: 462, Failures: 0, Errors: 0, Skipped: 70 Tests run: 208, Failures: 0, Errors: 0, Skipped: 141 (cherry picked from commit a35fc38)
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…ver limit (apache#2535) Contributed by Sumangala Patki Change-Id: I05d7e4245735aa14c18266bf41456217b2249151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server currently supports listing a maximum of 5000 items in a page during a listStatus call. This PR updates the default value of this page-size configuration from 500 to 5000, in order to be consistent with the max limit and allow retrieving the complete list in one server call when possible.
Modified an existing test to validate driver support for ListStatus returning 5000 items. Complete test results posted in the comments section.