HADOOP-17514. Remove trace subcommand from hadoop CLI. #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jojochuang
reviewed
Feb 22, 2021
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Assuming we will ultimately switch to OpenTracing/OpenTelemetry, we still want a trace subcommand?
Member
Author
|
@jojochuang TraceAdmin protocol was removed by @smengcl because it is not needed for alternative tracer impl. If it turned out to be needed, we can add it back again. Since trace subcommand was actually dynamic reconfiguration functionality, adding generic protocol which can be used for other purposes could be an option. |
Contributor
|
Good catch. Actually because I'm +1 on removing this right now. |
smengcl
approved these changes
Mar 11, 2021
Member
Author
|
Thanks, @smengcl. I'm merging this. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HADOOP-17514
TraceAdmin protocol and utility class were removed by HADOOP-17424.