-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8.1 due to CVEs #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I worry about the lines on the json-smart import <!-- HACK. Transitive dependency for nimbus-jose-jwt. Needed for
packaging. Please re-check this version when updating
nimbus-jose-jwt. Please read HADOOP-14903 for more details.
-->The assumption here is: nimbus-jose-jwt needs to be updated in sync, and kerby. Are there any related JIRAS/issues we could reference there? |
|
I just tested locally and realized that |
& |
|
@steveloughran I have run tests locally for some affected modules and they seem fine. |
|
|
|
FYI @ayushtkn @jojochuang , if you would also like to take a look. |
|
💔 -1 overall
This message was automatically generated. |
|
It looks like, since we touched |
|
I don't worry too much about these two dependency bump. Netty, Jetty and jackson-databind are usually more brittle. |
|
well, we did successfully run the full 17+ build test run. And I now know how to force a full retest after a JAR update. Looking at the test failures, I'm going to say "unrelated"...certainly the ZK one is known to be brittle |
+1, I also feel so good to know about this. |
hadoop-project/pom.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess 9.8.1 is also available? Or did I check it wrong, If so we can choose that?
Otherwise the build seems happy,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, 9.8.1 seems latest. Maven repository showed highest usage for 9.8 and 9.8.1 is quite recent, hence I thought of using 9.8. However, I think we can use 9.8.1 as things look good with 9.8 so there should not be much difference with 9.8.1 either.
Edit: Just realized 9.8 is also recent only, so I agree we should go with 9.8.1
c511437 to
e869d30
Compare
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1(Pending Jenkins)
The build should take a day, If nothing bothers there, Will wait for a day post that.
If anyone has concerns with this, do let me know,
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Test failures doesn't seems related, mostly due to timeouts, or are known flaky |
… to CVEs (#2895). Contributed by Viraj Jasani. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Conflicts: LICENSE-binary
… to CVEs (#2895). Contributed by Viraj Jasani. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Conflicts: LICENSE-binary
… to CVEs (#2895). Contributed by Viraj Jasani. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
… to CVEs (apache#2895). Contributed by Viraj Jasani. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Cherry-pick: HADOOP-17633. Bump json-smart to 2.4.2 and nimbus-jose-jwt to 9.8 due to CVEs (apache#2895). Contributed by Viraj Jasani. and bump json-smart to 2.4.7 Change-Id: I07d3b9a0917bf5b1a5bc9bfdeee6cb4c7316da0f
No description provided.