HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics #2909

virajjasani · 2021-04-14T17:28:00Z

No description provided.

hadoop-yetus · 2021-04-14T20:29:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 21s		trunk passed
+1 💚	compile	21m 10s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 6s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 33s		trunk passed
+1 💚	javadoc	1m 4s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 42s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 22s		trunk passed
+1 💚	shadedclient	15m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 53s		the patch passed
+1 💚	compile	20m 16s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 16s		the patch passed
+1 💚	compile	18m 13s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		hadoop-common-project/hadoop-common: The patch generated 0 new + 25 unchanged - 5 fixed = 25 total (was 30)
+1 💚	mvnsite	1m 30s		the patch passed
+1 💚	javadoc	1m 2s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 36s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 31s		the patch passed
+1 💚	shadedclient	15m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	17m 35s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 57s		The patch does not generate ASF License warnings.
		179m 49s

Reason	Tests
Failed junit tests	hadoop.metrics2.source.TestJvmMetrics

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/1/artifact/out/Dockerfile
GITHUB PR	#2909
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 7efd521557c3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 207f35fc728284afe04e0e1b481877b6de7009c4
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/1/testReport/
Max. process+thread count	1378 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-04-15T05:27:25Z

@Apache9 @aajisaka Could you please take a look?
Thanks

virajjasani · 2021-04-15T05:27:59Z

Test failure has been taken care of in recent commit

aajisaka

~~TestJvmMetrics failure seems related. Would you fix it?~~

aajisaka

Test failure has been taken care of in recent commit

Okay, it has been fixed.

virajjasani · 2021-04-15T06:24:09Z

Incompatible change flag in Jira is enough right? Or I should specify the same in PR title?

hadoop-yetus · 2021-04-15T08:43:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 29s		trunk passed
+1 💚	compile	28m 16s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	19m 8s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 31s		trunk passed
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 18s		trunk passed
+1 💚	shadedclient	15m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	20m 42s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 42s		the patch passed
+1 💚	compile	18m 7s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 7s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		hadoop-common-project/hadoop-common: The patch generated 0 new + 25 unchanged - 5 fixed = 25 total (was 30)
+1 💚	mvnsite	1m 31s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 29s		the patch passed
+1 💚	shadedclient	15m 48s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 32s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 57s		The patch does not generate ASF License warnings.
		195m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/2/artifact/out/Dockerfile
GITHUB PR	#2909
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 75899f31b755 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e28757a`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/2/testReport/
Max. process+thread count	1378 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2909/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2021-04-15T09:02:44Z

Incompatible change flag in Jira is enough right?

I added the flag in the jira and wrote a release note. It is enough.

aajisaka · 2021-04-15T09:05:31Z

Thank you @virajjasani and @Apache9 !

…pache#2909) Reviewed-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics

e28757a

virajjasani force-pushed the HADOOP-17524-trunk branch from 207f35f to e28757a Compare April 15, 2021 05:26

Apache9 approved these changes Apr 15, 2021

View reviewed changes

aajisaka requested changes Apr 15, 2021

View reviewed changes

aajisaka approved these changes Apr 15, 2021

View reviewed changes

aajisaka merged commit 9179638 into apache:trunk Apr 15, 2021

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics (a…

a7f926d

…pache#2909) Reviewed-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

slfan1989 mentioned this pull request Apr 10, 2024

HIVE-28191. Upgrade Hadoop Version to 3.4.0. apache/hive#5187

Closed

maxgio92 mentioned this pull request Oct 1, 2024

feat(hive): add apache hive package wolfi-dev/os#29412

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics #2909

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics #2909

virajjasani commented Apr 14, 2021

hadoop-yetus commented Apr 14, 2021

virajjasani commented Apr 15, 2021

virajjasani commented Apr 15, 2021

aajisaka left a comment •

edited

Loading

aajisaka left a comment

virajjasani commented Apr 15, 2021

hadoop-yetus commented Apr 15, 2021

aajisaka commented Apr 15, 2021

aajisaka commented Apr 15, 2021

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics #2909

HADOOP-17524. Remove EventCounter and Log counters from JVM Metrics #2909

Conversation

virajjasani commented Apr 14, 2021

hadoop-yetus commented Apr 14, 2021

virajjasani commented Apr 15, 2021

virajjasani commented Apr 15, 2021

aajisaka left a comment • edited Loading

Choose a reason for hiding this comment

aajisaka left a comment

Choose a reason for hiding this comment

virajjasani commented Apr 15, 2021

hadoop-yetus commented Apr 15, 2021

aajisaka commented Apr 15, 2021

aajisaka commented Apr 15, 2021

aajisaka left a comment •

edited

Loading