HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer #3169

virajjasani · 2021-07-02T07:25:44Z

No description provided.

tomscut

LGTM

virajjasani · 2021-07-02T08:34:03Z

Thanks @tomscut for the review.
@aajisaka could you please take a look?
Thanks

ferhui · 2021-07-02T08:59:24Z

...ject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeSyncer.java

-        LOG.error("Failed to create directory for downloading log " +
-                "segments: %s. Stopping Journal Node Sync.",
+        LOG.error("Failed to create directory for downloading log "
+                + "segments: {}. Stopping Journal Node Sync.",


Guess CI will report checkstyle problem.

Sure, let me put it back to how it was.

hadoop-yetus · 2021-07-02T14:36:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 13s		trunk passed
+1 💚	compile	1m 25s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 15s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 0s		trunk passed
+1 💚	mvnsite	1m 24s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 26s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 16s		trunk passed
+1 💚	shadedclient	18m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 18s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	1m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 16s		the patch passed
+1 💚	javadoc	0m 48s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 25s		the patch passed
+1 💚	shadedclient	18m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	337m 18s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		429m 17s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/1/artifact/out/Dockerfile
GITHUB PR	#3169
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 9916232dc298 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d1c0604`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/1/testReport/
Max. process+thread count	2026 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-07-02T14:51:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	30m 32s		trunk passed
+1 💚	compile	1m 23s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 16s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 23s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 30s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 6s		trunk passed
+1 💚	shadedclient	16m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 16s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 16s		the patch passed
+1 💚	compile	1m 9s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	1m 9s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	javadoc	0m 46s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 21s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 16s		the patch passed
+1 💚	shadedclient	16m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	239m 8s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		323m 23s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/2/artifact/out/Dockerfile
GITHUB PR	#3169
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 8424f1079d4a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `507a47a`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/2/testReport/
Max. process+thread count	3033 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3169/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-07-02T15:06:43Z

@ferhui could you please take a look? Thanks

ferhui

+1

ferhui · 2021-07-05T01:23:12Z

@virajjasani Thanks for contribution. @aajisaka @tomscut Thanks for review.
Merged to trunk.

…3169) (cherry picked from commit da575a5)

…pache#3169)

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer

d1c0604

tomscut approved these changes Jul 2, 2021

View reviewed changes

ferhui reviewed Jul 2, 2021

View reviewed changes

addressing comment by @ferhui

507a47a

virajjasani requested a review from ferhui July 2, 2021 09:27

aajisaka approved these changes Jul 3, 2021

View reviewed changes

ferhui approved these changes Jul 5, 2021

View reviewed changes

ferhui merged commit da575a5 into apache:trunk Jul 5, 2021

aajisaka pushed a commit that referenced this pull request Jul 5, 2021

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer (#…

2d56335

…3169) (cherry picked from commit da575a5)

aajisaka pushed a commit that referenced this pull request Jul 5, 2021

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer (#…

4912e4c

…3169) (cherry picked from commit da575a5)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer (a…

90318bd

…pache#3169)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer #3169

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer #3169

Uh oh!

virajjasani commented Jul 2, 2021

Uh oh!

tomscut left a comment

Uh oh!

virajjasani commented Jul 2, 2021

Uh oh!

ferhui Jul 2, 2021

Uh oh!

virajjasani Jul 2, 2021

Uh oh!

hadoop-yetus commented Jul 2, 2021

Uh oh!

hadoop-yetus commented Jul 2, 2021

Uh oh!

virajjasani commented Jul 2, 2021

Uh oh!

ferhui left a comment

Uh oh!

ferhui commented Jul 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer #3169

HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer #3169

Uh oh!

Conversation

virajjasani commented Jul 2, 2021

Uh oh!

tomscut left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Jul 2, 2021

Uh oh!

ferhui Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

virajjasani Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 2, 2021

Uh oh!

hadoop-yetus commented Jul 2, 2021

Uh oh!

virajjasani commented Jul 2, 2021

Uh oh!

ferhui left a comment

Choose a reason for hiding this comment

Uh oh!

ferhui commented Jul 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants