-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16281. Fix flaky unit tests failed due to timeout #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
There are some more tests, which just failed on timeout here: Can you sort them up as well |
Thanks @ayushtkn for the information. I'd be happy to change them all. And I'll do that later. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanx @tomscut, There is one test which still failed with timeout in one of the build. Apart, I don't think we should add timeout for the tests which doesn't have it now. I see you introduced timeouts for some. I don't want to risk seeing them fail in future with timeouts, the builds times are very unpredictable nowadays |
Thanks @ayushtkn for your review and comment. I fixed this failed unit test I added timeout on this The other three places I added timeout because they all extend from |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @jojochuang @tasanuma @ferhui , could you please take a look at this. Thanks. |
JIRA: HDFS-16281
I found that this unit test
TestViewFileSystemOverloadSchemeWithHdfsSchemefailed several times due to timeout. Can we change the timeout for some methods from3sto30sto be consistent with the other methods?