-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18093: Better exception handling for testFileStatusOnMountLink #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…() in ViewFsBaseTest.java
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
+1, if the build comes green
|
💔 -1 overall
This message was automatically generated. |
|
this test failure seems to happen on trunk without my change as well. Are we good to merge this pull request? "TestIPC.testIOEOnListenerAccept:652 Expected an EOFException to have been thrown" |
|
Yeps, we are. TestIPC is flaky and is being tracked seperately. |
|
Awesome! thanks @ayushtkn! |
|
Thanx @xinglin for the contribution!!! |
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
|
@ayushtkn Can you approve and commit my other pull requests to get this change merged into lower supported versions? I should have mentioned targeted version in my jira issue. |
|
@xinglin Done. Thanx for the contribution!!! |
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. (apache#3929) Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 0d17b62)
Description of PR
Use
@Test(expected = FileNotFoundException.class)to indicate we are expecting a FileNotFound exception. This makes it consistent with how similar exceptions are handled in this class as well.How was this patch tested?
mvn test -Dtest=TestViewFsLocalFs