Skip to content

Conversation

@xinglin
Copy link
Contributor

@xinglin xinglin commented Jan 24, 2022

Description of PR

Use @Test(expected = FileNotFoundException.class) to indicate we are expecting a FileNotFound exception. This makes it consistent with how similar exceptions are handled in this class as well.

How was this patch tested?

mvn test -Dtest=TestViewFsLocalFs

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
+1, if the build comes green

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 40m 49s trunk passed
+1 💚 compile 30m 57s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 26m 26s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 5s trunk passed
+1 💚 mvnsite 1m 53s trunk passed
+1 💚 javadoc 1m 23s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 54s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 3m 7s trunk passed
+1 💚 shadedclient 30m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 27s the patch passed
+1 💚 compile 32m 35s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 32m 35s the patch passed
+1 💚 compile 20m 41s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 20m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 57s hadoop-common-project/hadoop-common: The patch generated 0 new + 82 unchanged - 1 fixed = 82 total (was 83)
+1 💚 mvnsite 1m 36s the patch passed
+1 💚 javadoc 1m 5s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 39s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 2m 38s the patch passed
+1 💚 shadedclient 25m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 17m 32s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
244m 55s
Reason Tests
Failed junit tests hadoop.ipc.TestIPC
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/artifact/out/Dockerfile
GITHUB PR #3918
JIRA Issue HADOOP-18093
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux bfe9b4da88db 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ac45e08
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/testReport/
Max. process+thread count 2319 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@xinglin
Copy link
Contributor Author

xinglin commented Jan 24, 2022

this test failure seems to happen on trunk without my change as well. Are we good to merge this pull request?

"TestIPC.testIOEOnListenerAccept:652 Expected an EOFException to have been thrown"

@ayushtkn
Copy link
Member

Yeps, we are. TestIPC is flaky and is being tracked seperately.
Will merge this by tomorrow if no further comments..

@xinglin
Copy link
Contributor Author

xinglin commented Jan 24, 2022

Awesome! thanks @ayushtkn!

@ayushtkn ayushtkn merged commit 0d17b62 into apache:trunk Jan 25, 2022
@ayushtkn
Copy link
Member

Thanx @xinglin for the contribution!!!

xinglin added a commit to xinglin/hadoop that referenced this pull request Jan 25, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
xinglin added a commit to xinglin/hadoop that referenced this pull request Jan 25, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
xinglin added a commit to xinglin/hadoop that referenced this pull request Jan 25, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
xinglin added a commit to xinglin/hadoop that referenced this pull request Jan 25, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
xinglin added a commit to xinglin/hadoop that referenced this pull request Jan 25, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
@xinglin
Copy link
Contributor Author

xinglin commented Jan 25, 2022

@ayushtkn Can you approve and commit my other pull requests to get this change merged into lower supported versions? I should have mentioned targeted version in my jira issue.

ayushtkn pushed a commit that referenced this pull request Jan 26, 2022
…() in ViewFsBaseTest.java (#3918). Contributed by Xing Lin. (#3931)

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
ayushtkn pushed a commit that referenced this pull request Jan 26, 2022
…() in ViewFsBaseTest.java (#3918). Contributed by Xing Lin. (#3933)

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
ayushtkn pushed a commit that referenced this pull request Jan 26, 2022
…() in ViewFsBaseTest.java (#3918). Contributed by Xing Lin. (#3929)

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
@ayushtkn
Copy link
Member

@xinglin Done. Thanx for the contribution!!!

bogthe pushed a commit to bogthe/hadoop that referenced this pull request Feb 2, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin. (apache#3929)

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
iwasakims pushed a commit that referenced this pull request Mar 13, 2022
…() in ViewFsBaseTest.java (#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
basapuram-kumar pushed a commit to acceldata-io/hadoop that referenced this pull request Jun 25, 2024
…() in ViewFsBaseTest.java (apache#3918). Contributed by Xing Lin.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 0d17b62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants