You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We modified the Groups.java file, manually checked the cache validity time in the initialization function of this file, and then threw an exception at an earlier position. Because what is thrown in ZKFailoverController.java is the cause of the exception information, which is RuntimeException.getCause(). Also, the cache validity time is used when creating a cacheBuilder. However, the check information in this cacheBuilder class is imperfect, so it leads to imperfection of the thrown information.
How was this patch tested?
we don't need more tests, because we just add some codes to check configuration.
For code changes:
Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
17m 6s
branch-2.10.2 passed
+1 💚
compile
15m 33s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
12m 28s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 8s
branch-2.10.2 passed
+1 💚
mvnsite
1m 41s
branch-2.10.2 passed
+1 💚
javadoc
1m 48s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 33s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
16m 11s
branch-2.10.2 passed
+1 💚
compile
13m 27s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
11m 17s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 11s
branch-2.10.2 passed
+1 💚
mvnsite
1m 45s
branch-2.10.2 passed
+1 💚
javadoc
1m 46s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 31s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
16m 17s
branch-2.10.2 passed
+1 💚
compile
13m 30s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
11m 19s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 11s
branch-2.10.2 passed
+1 💚
mvnsite
1m 46s
branch-2.10.2 passed
+1 💚
javadoc
1m 39s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 31s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
16m 6s
branch-2.10.2 passed
+1 💚
compile
14m 20s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
13m 0s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 11s
branch-2.10.2 passed
+1 💚
mvnsite
1m 47s
branch-2.10.2 passed
+1 💚
javadoc
1m 40s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 24s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
16m 9s
branch-2.10.2 passed
+1 💚
compile
13m 22s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
11m 20s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 13s
branch-2.10.2 passed
+1 💚
mvnsite
1m 47s
branch-2.10.2 passed
+1 💚
javadoc
1m 44s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 29s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10.2 Compile Tests _
+1 💚
mvninstall
16m 2s
branch-2.10.2 passed
+1 💚
compile
13m 25s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
11m 16s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚
checkstyle
1m 13s
branch-2.10.2 passed
+1 💚
mvnsite
1m 46s
branch-2.10.2 passed
+1 💚
javadoc
1m 46s
branch-2.10.2 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
1m 30s
branch-2.10.2 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
We modified the Groups.java file, manually checked the cache validity time in the initialization function of this file, and then threw an exception at an earlier position. Because what is thrown in ZKFailoverController.java is the cause of the exception information, which is RuntimeException.getCause(). Also, the cache validity time is used when creating a cacheBuilder. However, the check information in this cacheBuilder class is imperfect, so it leads to imperfection of the thrown information.
How was this patch tested?
we don't need more tests, because we just add some codes to check configuration.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?