-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18344. Upgrade AWS SDK to 1.12.262 #4637
HADOOP-18344. Upgrade AWS SDK to 1.12.262 #4637
Conversation
Test failures
I will need to see if this is a regression. I believe i have disabled setting storage class.
|
CLI tests good. but they are all logging a warning about unset storage class. Filed HADOOP-18371 |
setup failure in ILoadTestS3ABulkDeleteThrottling; filed HADOOP-18372
|
test failures occur on trunk even without sdk upgrade
|
ILoadTestS3ABulkDeleteThrottling (also failing without the upgrade) is fixed in #4642 |
the storage class tests all work when i switch from bytebuffer as the upload buffering, as does the OOM. |
CSE-KMS mode failing, but as i've not tried it before, can't blame the SDK
SSE-KMS works so it could be key config/permissions. |
Fixes CVE-2018-7489 in shaded jackson. +Add more commands in testing.md to the CLI tests needed when qualifying a release Change-Id: If8020ad581d290f0cbe322184e860b1e3f4aeffe
9800dd2
to
7e1b620
Compare
💔 -1 overall
This message was automatically generated. |
remove a space at an EOL Change-Id: I819e210f988b58281440d6834aea4203e20ccee1
Okay looks good. running the tests once complete will give a +1 |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, test run successful with my configs in us-west-1.
# expect the iostatistics object_list_request value to be O(directories) | ||
bin/hadoop fs -ls -R $BUCKET/ | ||
|
||
# expect the iostatistics object_list_request and op_get_content_summary values to be 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is a extra space here at the end as pointed by Yetus,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed that last night; will push and then merge
Update LICENSE-binary with the new AWS SDK version. Followup to #4637. Contributed by Steve Loughran
Fixes CVE-2018-7489 in shaded jackson. +Add more commands in testing.md to the CLI tests needed when qualifying a release Contributed by Steve Loughran
Fixes CVE-2018-7489 in shaded jackson. +Add more commands in testing.md to the CLI tests needed when qualifying a release Contributed by Steve Loughran
aah, forgot that license-binary change. pushed up a followup, and for the backports merged the two changes |
💔 -1 overall
This message was automatically generated. |
Fixes CVE-2018-7489 in shaded jackson. +Add more commands in testing.md to the CLI tests needed when qualifying a release Contributed by Steve Loughran
Update LICENSE-binary with the new AWS SDK version. Followup to apache#4637. Contributed by Steve Loughran
Description of PR
How was this patch tested?
object store test in progress. first run had two failures I'd not see before