-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16719. Remove unused import in hadoop-hdfs module #4710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the build passes.
Changes LGTM
LGTM +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I take that back Post reading the comment from @steveloughran here:
#4390 (comment)
So, lets not bother the imports, Anyway I don't think unused imports have any performance impact during runtime, so let them stay
Thanks @slfan1989 @ayushtkn for your review. I will read https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md carefully and close this PR. |
💔 -1 overall
This message was automatically generated. |
Description of PR
During reading code of hadoop-hdfs module, I found that there are some unused import in some classes, such as unused import TrustedChannelResolver in WhitelistBasedTrustedChannelResolver.java