YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp #4992

ashutoshcipher · 2022-10-09T23:49:19Z

Description of PR

Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp

JIRA - YARN-11336

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…webapp

hadoop-yetus · 2022-10-10T01:34:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 2s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 5s		trunk passed
+1 💚	compile	0m 49s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 48s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 36s		trunk passed
+1 💚	mvnsite	0m 53s		trunk passed
+1 💚	javadoc	0m 38s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 16s		trunk passed
+1 💚	shadedclient	24m 0s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	0m 40s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 40s		the patch passed
+1 💚	compile	0m 37s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 39s		the patch passed
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 5s		the patch passed
+1 💚	shadedclient	23m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 10s		hadoop-yarn-applications-catalog-webapp in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		103m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/1/artifact/out/Dockerfile
GITHUB PR	#4992
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 144e9762e39e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8cc28c8`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/1/testReport/
Max. process+thread count	530 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ashutoshcipher · 2022-10-10T01:54:20Z

@aajisaka - Please help in reviewing this PR. Thanks.

aajisaka

+1

aajisaka

Cancelling my +1. Would you add the following dependency into the module?

    <dependency>
      <groupId>org.junit.platform</groupId>
      <artifactId>junit-platform-launcher</artifactId>
      <scope>test</scope>
    </dependency>

ashutoshcipher · 2022-10-11T07:56:18Z

Hi @aajisaka, I am sorry that I missed it. Adding it in my next commit.

hadoop-yetus · 2022-10-11T14:28:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 7s		trunk passed
+1 💚	compile	0m 49s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 46s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 33s		trunk passed
+1 💚	mvnsite	0m 51s		trunk passed
+1 💚	javadoc	0m 39s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 13s		trunk passed
+1 💚	shadedclient	23m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 38s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 38s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 36s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 40s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 2s		the patch passed
+1 💚	shadedclient	23m 25s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 3s		hadoop-yarn-applications-catalog-webapp in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		104m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/2/artifact/out/Dockerfile
GITHUB PR	#4992
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 025e0082e842 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cad32cd`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/2/testReport/
Max. process+thread count	638 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4992/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

aajisaka

+1, thanks.

ashutoshcipher · 2022-10-25T07:53:59Z

Thanks @aajisaka for reviewing/merging.

…webapp (apache#4992) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-…

8cc28c8

…webapp

slfan1989 approved these changes Oct 10, 2022

View reviewed changes

ashutoshcipher marked this pull request as ready for review October 10, 2022 01:53

aajisaka approved these changes Oct 11, 2022

View reviewed changes

aajisaka requested changes Oct 11, 2022

View reviewed changes

Adding junit-platform-launcher

cad32cd

ashutoshcipher requested a review from aajisaka October 11, 2022 13:23

aajisaka approved these changes Oct 25, 2022

View reviewed changes

aajisaka merged commit 21b7790 into apache:trunk Oct 25, 2022

slfan1989 mentioned this pull request Jan 30, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp #4992

YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp #4992

ashutoshcipher commented Oct 9, 2022

hadoop-yetus commented Oct 10, 2022

ashutoshcipher commented Oct 10, 2022

aajisaka left a comment

aajisaka left a comment

ashutoshcipher commented Oct 11, 2022

hadoop-yetus commented Oct 11, 2022

aajisaka left a comment

ashutoshcipher commented Oct 25, 2022

YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp #4992

YARN-11336. Upgrade Junit 4 to 5 in hadoop-yarn-applications-catalog-webapp #4992

Conversation

ashutoshcipher commented Oct 9, 2022

Description of PR

For code changes:

hadoop-yetus commented Oct 10, 2022

ashutoshcipher commented Oct 10, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka left a comment

Choose a reason for hiding this comment

ashutoshcipher commented Oct 11, 2022

hadoop-yetus commented Oct 11, 2022

aajisaka left a comment

Choose a reason for hiding this comment

ashutoshcipher commented Oct 25, 2022