HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider #5880

xinglin · 2023-07-24T05:53:58Z

Description of PR

We noticed a few checkstyle warnings when backporting HDFS-17030 from trunk to branch-3.3. The yetus build was not stable at that time and we did not notice the newly added checkstyle warnings. Fix them now.

How was this patch tested?

unit test for TestObserverReadProxyProvider

xinglin@xinglin-mn1 ~/p/h/t/hadoop-hdfs-project (HDFS-17118)> mvn test -Dtest=TestObserverReadProxyProvider
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.99 s - in org.apache.hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0

mvn build for hadoop-hdfs.

xinglin@xinglin-mn1 ~/p/h/t/hadoop-hdfs-project (HDFS-17118)> mvn package -Dtar -Pdist -DskipTests -Dmaven.javadoc.failOnError=false
[INFO] Reactor Summary for Apache Hadoop HDFS Project 3.4.0-SNAPSHOT:
[INFO]
[INFO] Apache Hadoop HDFS Client .......................... SUCCESS [04:17 min]
[INFO] Apache Hadoop HDFS ................................. SUCCESS [03:33 min]
[INFO] Apache Hadoop HDFS Native Client ................... SUCCESS [  4.238 s]
[INFO] Apache Hadoop HttpFS ............................... SUCCESS [  6.406 s]
[INFO] Apache Hadoop HDFS-NFS ............................. SUCCESS [  3.799 s]
[INFO] Apache Hadoop HDFS-RBF ............................. SUCCESS [03:59 min]
[INFO] Apache Hadoop HDFS Project ......................... SUCCESS [  0.143 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12:04 min
[INFO] Finished at: 2023-07-23T23:03:01-07:00
[INFO] ------------------------------------------------------------------------

…yProvider

hadoop-yetus · 2023-07-24T10:38:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 20s		trunk passed
+1 💚	compile	0m 55s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 52s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 46s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 50s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 13s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 58s		trunk passed
+1 💚	shadedclient	22m 0s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	0m 47s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 47s		the patch passed
+1 💚	compile	0m 42s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	mvnsite	0m 49s		the patch passed
+1 💚	javadoc	0m 39s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 59s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 51s		the patch passed
+1 💚	shadedclient	22m 4s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	187m 57s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		282m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/1/artifact/out/Dockerfile
GITHUB PR	#5880
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 5607d5c71821 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9c877e4`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/1/testReport/
Max. process+thread count	3952 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-07-24T17:39:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 31s		trunk passed
+1 💚	compile	0m 55s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 49s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 44s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 17s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 56s		trunk passed
+1 💚	shadedclient	22m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 46s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 43s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 43s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	mvnsite	0m 46s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 10s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 56s		the patch passed
+1 💚	shadedclient	21m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	192m 46s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		289m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/2/artifact/out/Dockerfile
GITHUB PR	#5880
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 86ebbec19892 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `dc6e9bd`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/2/testReport/
Max. process+thread count	3559 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

xinglin · 2023-07-24T22:01:27Z

Hi @goiri,

Can you take a look at this PR? Fix some checkstyle warnings introduced in HDFS-17030.

The uncheck cast error was not detected during the builds when merging into trunk. Not sure why that was the case.

I have also made these changes as part of the backport PR for branch-3.3: #5878.

simbadzina

LGTM.

xinglin · 2023-07-28T16:10:50Z

Hi @goiri,

Could you take a look at this PR? thanks,

xinglin · 2023-08-01T04:44:39Z

Hi @goiri,

Could you review it? thanks,

...s/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java

hadoop-yetus · 2023-08-05T04:11:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	8m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 14s		trunk passed
+1 💚	compile	0m 57s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 47s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 46s		trunk passed
+1 💚	mvnsite	0m 57s		trunk passed
+1 💚	javadoc	0m 51s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	1m 14s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 2s		trunk passed
+1 💚	shadedclient	22m 8s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 48s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 33s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	mvnsite	0m 47s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	1m 6s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 54s		the patch passed
+1 💚	shadedclient	22m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	188m 52s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		290m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/3/artifact/out/Dockerfile
GITHUB PR	#5880
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b80c0ff63ebb 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9827fb8`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/3/testReport/
Max. process+thread count	3778 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5880/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…yProvider (apache#5880)

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProx…

9c877e4

…yProvider

More suppresswarning.

dc6e9bd

xinglin marked this pull request as ready for review July 24, 2023 21:58

simbadzina approved these changes Jul 24, 2023

View reviewed changes

tomscut approved these changes Jul 25, 2023

View reviewed changes

goiri approved these changes Aug 4, 2023

View reviewed changes

...s/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java Outdated Show resolved Hide resolved

Moved suppressWarning to a separate line

9827fb8

github-actions bot added HDFS trunk labels Aug 4, 2023

goiri approved these changes Aug 5, 2023

View reviewed changes

goiri merged commit 55e8301 into apache:trunk Aug 5, 2023

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProx…

72ce8e7

…yProvider (apache#5880)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider #5880

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider #5880

Uh oh!

xinglin commented Jul 24, 2023 •

edited

Loading

Uh oh!

hadoop-yetus commented Jul 24, 2023

Uh oh!

hadoop-yetus commented Jul 24, 2023

Uh oh!

xinglin commented Jul 24, 2023 •

edited

Loading

Uh oh!

simbadzina left a comment

Uh oh!

xinglin commented Jul 28, 2023

Uh oh!

xinglin commented Aug 1, 2023

Uh oh!

Uh oh!

hadoop-yetus commented Aug 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider #5880

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider #5880

Uh oh!

Conversation

xinglin commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

Uh oh!

hadoop-yetus commented Jul 24, 2023

Uh oh!

hadoop-yetus commented Jul 24, 2023

Uh oh!

xinglin commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simbadzina left a comment

Choose a reason for hiding this comment

Uh oh!

xinglin commented Jul 28, 2023

Uh oh!

xinglin commented Aug 1, 2023

Uh oh!

Uh oh!

hadoop-yetus commented Aug 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xinglin commented Jul 24, 2023 •

edited

Loading

xinglin commented Jul 24, 2023 •

edited

Loading