YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. #6132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help review this PR? Thank you very much! |
goiri
reviewed
Oct 10, 2023
| pw.println("\tWeight : " + "0.30"); | ||
| pw.println("\tState : " + "RUNNING"); | ||
| pw.println("\tMinResource : " + "<memory : 0, vCores:10>"); | ||
| pw.println("\tMaxResource : " + "<memory : 8192, vCores:0>"); |
Member
There was a problem hiding this comment.
Why not just a single one without the +?
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your help in reviewing the code! I wrote this unit test based on the original unit test. I will improve this part of the code.
|
|
||
| QueueInfo queueInfo = response.getQueueInfo(); | ||
| Assert.assertNotNull(queueInfo); | ||
| Assert.assertEquals(queueInfo.getQueueName(), "root"); |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Oct 25, 2023
| writer.print("\tState : "); | ||
| writer.println(queueInfo.getQueueState()); | ||
| writer.print("\tMinResource : "); | ||
| writer.println("<memory : " + queueInfo.getMinResourceMemory() + |
Member
There was a problem hiding this comment.
We are doing this operation a lot, we should have some function to generate the String.
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion! I will refactor this part of the code.
Contributor
Author
|
@goiri Can you help review this PR again? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help review this PR again? Thank you very much! |
goiri
approved these changes
Nov 8, 2023
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds.
In YARN Federation, clients connect to the Router, and we need to ensure that basic commands related to applications and queues operate smoothly. We will improve certain commands to help users identify that they are using YARN Federation.
Currently, the 'yarn queue status' command can only display queue information for the CapacityScheduler. In this PR, we are adding the capability to display information for the FairScheduler. Additionally, if the user has enabled Federation mode, it will display Federation-related messages.
Before the modification
These queue details are intended for display with the
CapacityScheduler. If the queue is managed by theFairScheduler, it may not provide meaningful information.After the modification
We present relevant information based on the queue details of the
FairScheduler.How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?