HDFS-17317. Improve the resource release for metaOut in DebugAdmin #6402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
I have triggered a new build: we need to get a green build before we can merge |
Member
Author
OK，Thanks |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
dismissed
their stale review
We have related failures: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6402/2/testReport/
Member
Author
|
@ayushtkn Here need flush first，had change it and need trigger a new CI build again? |
ayushtkn
reviewed
Jan 3, 2024
| smallBufferSize)); | ||
| BlockMetadataHeader.writeHeader(metaOut, checksum); | ||
| metaOut.close(); | ||
| metaOut.flush(); |
Member
There was a problem hiding this comment.
I think close itself is ok, we can avoid closing in the finally block if the stream is already closing, rather than flushing here & then closing below, close would be calling flush before closing itself.
in general I don't think it isn't a big problem, maybe just dereference the metaOut after close
metaOut.close();
metaOut = null;
Member
There was a problem hiding this comment.
I think you got me wrong, only 1 line was required, finally should have remained, if there is an exception before close, the stream would remain open otherwise
Member
Author
There was a problem hiding this comment.
Yes，I misstaked，keep finally block and add 1 line. @ayushtkn
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
@ayushtkn https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6402/7/ UT seems all success，but the result is not all passed |
Member
Author
|
@ayushtkn could you help to merge？ |
Member
|
there is some release branching going out, let me recircle once that is done & I will merge this |
Member
Author
OK，other release branch testing seems not in github CI process |
slfan1989
approved these changes
Jan 5, 2024
|
💔 -1 overall
This message was automatically generated. |
xuzifu666
changed the title
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…pache#6402). Contributed by xy. Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
DebugAdmin metaOut not need multiple close
How was this patch tested?
not need
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?