HDFS-17396. BootstrapStandby should download rollback image during RollingUpgrade #6583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goiri
reviewed
Feb 24, 2024
| int nnIdx, List<Integer> txids) { | ||
|
|
||
| for (File nameDir : getNameNodeCurrentDirs(cluster, nnIdx)) { | ||
| LOG.info("examining name dir with files: " + |
...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSImageTestUtil.java
Show resolved
Hide resolved
|
|
||
| for (int i = 1; i < maxNNCount; i++) { | ||
| assertTrue("NameNodes should all have the rollback FSImage", | ||
| cluster.getNameNode(i).getFSImage().hasRollbackFSImage()); |
Member
There was a problem hiding this comment.
Easier to read if you extract the nn = cluster.getNameNode(i);
| // Start rolling upgrade | ||
| fs.rollingUpgrade(RollingUpgradeAction.PREPARE); | ||
| RollingUpgradeInfo info = fs.rollingUpgrade(RollingUpgradeAction.QUERY); | ||
| while (!info.createdRollbackImages()) { |
Member
There was a problem hiding this comment.
This is unbounded. Can you use LambdaTestUtils#wait or similar?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
added 2 commits
February 28, 2024 09:57
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
added 2 commits
March 4, 2024 16:47
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Due to HDFS-17178, BootstrapStandby can now succeed during a RollingUpgrade. This can lead to an edge case where the bootstrapped NameNode does not have the fsimage_rollback_N file locally so it does not recognize that it is in a RollingUpgrade. This means the bootstrapped NameNode will overwrite the VERSION file during a checkpoint because it does not know that the NameService is in a RollingUpgrade.
BootstrapStandby needs to download the fsimage_rollback_N file in addition to the normal fsimage_N file so that the bootstrapped node correctly recognizes the RollingUpgrade state of the NameService.
How was this patch tested?
Added unit tests to cover the scenario and verify the rollback image is downloaded.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?