-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17299. Adding rack failure tolerance when creating a new file #6614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Updated some tests, some of the tests are false positives so can be ignored if failing in main hadoop repo as well.
|
|
💔 -1 overall
This message was automatically generated. |
|
@ritegarg Can you please check if the checkstyle warning is relevant? |
| * least two replicas are needed. | ||
| */ | ||
| @Test(timeout=50000) | ||
| @Test(timeout=600000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to increase the timeout by 10x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, we needed to add this commit 01d950a same as that in trunk/3.3
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
All the tests (except for 1 test) that failed in this build are flaky. They are failing in daily build also. Check here for the latest build. @ritegarg Can you please check if this is flaky too? Thank you ! |
I ran the tests locally with and without my changes and I am observing same failure in both. |
|
💔 -1 overall
This message was automatically generated. |
shahrs87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes.
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
shahrs87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 ltgm. Thank you @ritegarg for the PR.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?