-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17433. metrics sumOfActorCommandQueueLength should only record valid commands. #6644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dineshchitlangia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, pending CI
@hfutatzhanghb thanks for finding this issue and contributing the fix.
Sir, thanks a lot for reviewing. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
shardulsadavarte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.. thanks
|
Thanks @hfutatzhanghb for the contribution and @shardulsadavarte for the review. |
Description of PR
We add an phone alarm on metrics sumOfActorCommandQueueLength when it beyond 3000.
Recently, we received the alarm and we found that
DatanodeCommand[] cmdswith array length equals to 0 wasstill put into queue and incrActorCmdQueueLength.
When processedCommandsOpAvgTime is high, those empty cmds were put into queue every heartbeat intervel.
sumOfActorCommandQueueLength should better only record valid commands.