HDFS-17508. RBF: MembershipStateStore can overwrite valid records when refreshing the local cache #6783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When the MembershipStore refreshes its cache, it will also call the overrideExpiredRecords() method, which will write the Expired state back to the state store. Due to a race condition this logic can overwrite valid records. overrideExpiredRecords should first check if the state of the record is already set to "EXPIRED" before it writes the record to the state store.
How was this patch tested?
Added unit test "TestStateStoreMembershipState#testRegistrationExpiredRaceCondition"
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?