Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented May 2, 2024

What changes were proposed in this pull request?

HADOOP-16179 attempted to remove dependency on kerb-simplekdc from hadoop-common. However, hadoop-auth still has a compile-scope dependency on the same, and hadoop-common proper depends on hadoop-auth. So kerb-simplekdc is still a transitive dependency of hadoop-common.

[INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ hadoop-common ---
[INFO] org.apache.hadoop:hadoop-common:jar:3.5.0-SNAPSHOT
...
[INFO] +- org.apache.hadoop:hadoop-auth:jar:3.5.0-SNAPSHOT:compile
...
[INFO] |  \- org.apache.kerby:kerb-simplekdc:jar:2.0.3:compile
[INFO] |     +- org.apache.kerby:kerb-client:jar:2.0.3:compile
[INFO] |     |  +- org.apache.kerby:kerby-config:jar:2.0.3:compile
[INFO] |     |  +- org.apache.kerby:kerb-common:jar:2.0.3:compile
[INFO] |     |  |  \- org.apache.kerby:kerb-crypto:jar:2.0.3:compile
[INFO] |     |  +- org.apache.kerby:kerb-util:jar:2.0.3:compile
[INFO] |     |  \- org.apache.kerby:token-provider:jar:2.0.3:compile
[INFO] |     \- org.apache.kerby:kerb-admin:jar:2.0.3:compile
[INFO] |        +- org.apache.kerby:kerb-server:jar:2.0.3:compile
[INFO] |        |  \- org.apache.kerby:kerb-identity:jar:2.0.3:compile
[INFO] |        +- org.apache.kerby:kerby-xdr:jar:2.0.3:compile
[INFO] |        \- org.jline:jline:jar:3.9.0:compile

This PR replaces the dependency in hadoop-auth with more specific modules.

https://issues.apache.org/jira/browse/HADOOP-19160

How was this patch tested?

Updated dependency tree:

[INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ hadoop-auth ---
[INFO] org.apache.hadoop:hadoop-auth:jar:3.5.0-SNAPSHOT
...
[INFO] +- org.apache.kerby:kerb-core:jar:2.0.3:compile
[INFO] |  \- org.apache.kerby:kerby-pkix:jar:2.0.3:compile
[INFO] |     +- org.apache.kerby:kerby-asn1:jar:2.0.3:compile
[INFO] |     \- org.apache.kerby:kerby-util:jar:2.0.3:compile
[INFO] +- org.apache.kerby:kerb-util:jar:2.0.3:compile
[INFO] |  +- org.apache.kerby:kerby-config:jar:2.0.3:compile
[INFO] |  \- org.apache.kerby:kerb-crypto:jar:2.0.3:compile

kerb-simplekdc is still a test-scope dependency via hadoop-minikdc (for both hadoop-auth and hadoop-common):

[INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ hadoop-auth ---
[INFO] org.apache.hadoop:hadoop-auth:jar:3.5.0-SNAPSHOT
...
[INFO] +- org.apache.hadoop:hadoop-minikdc:jar:3.5.0-SNAPSHOT:test
[INFO] |  +- commons-io:commons-io:jar:2.14.0:test
[INFO] |  \- org.apache.kerby:kerb-simplekdc:jar:2.0.3:test

Hadoop trunk compiles fine locally.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending a successful build.

add a pr to our release-support module to add the lib as something to block a release for
https://github.com/apache/hadoop-release-support/blob/main/build.xml#L342

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 22s Maven dependency ordering for branch
+1 💚 mvninstall 36m 18s trunk passed
+1 💚 compile 19m 22s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 17m 46s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 mvnsite 1m 17s trunk passed
+1 💚 javadoc 1m 16s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 9s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 shadedclient 131m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 0m 33s the patch passed
+1 💚 compile 18m 16s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 18m 16s the patch passed
+1 💚 compile 17m 27s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 17m 27s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 17s the patch passed
+1 💚 javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 9s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 shadedclient 46m 16s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 29s hadoop-project in the patch passed.
+1 💚 unit 3m 33s hadoop-auth in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
241m 56s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6788/1/artifact/out/Dockerfile
GITHUB PR #6788
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux e05ffd831084 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / dc61c8f
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6788/1/testReport/
Max. process+thread count 526 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-auth U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6788/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@adoroszlai adoroszlai merged commit 2645898 into apache:trunk May 3, 2024
@adoroszlai adoroszlai deleted the HADOOP-19160 branch May 3, 2024 10:57
@adoroszlai
Copy link
Contributor Author

Thanks @steveloughran for the review.

adoroszlai added a commit to adoroszlai/hadoop that referenced this pull request May 3, 2024
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants