-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19160. hadoop-auth should not depend on kerb-simplekdc #6788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 pending a successful build.
add a pr to our release-support module to add the lib as something to block a release for
https://github.com/apache/hadoop-release-support/blob/main/build.xml#L342
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @steveloughran for the review. |
What changes were proposed in this pull request?
HADOOP-16179 attempted to remove dependency on
kerb-simplekdcfromhadoop-common. However,hadoop-authstill has acompile-scope dependency on the same, andhadoop-commonproper depends onhadoop-auth. Sokerb-simplekdcis still a transitive dependency ofhadoop-common.This PR replaces the dependency in
hadoop-authwith more specific modules.https://issues.apache.org/jira/browse/HADOOP-19160
How was this patch tested?
Updated dependency tree:
kerb-simplekdcis still atest-scope dependency viahadoop-minikdc(for bothhadoop-authandhadoop-common):Hadoop
trunkcompiles fine locally.