HADOOP-18325: Fix test failures due to missing config #6847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
|
🎊 +1 overall
This message was automatically generated. |
saxenapranav
suggested changes
Jun 7, 2024
| metricAccountKey); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new IOException("Exception while initializing metric credentials " + e); | ||
| if (!metricAccountName.equals(EMPTY_STRING) && !metricAccountKey.equals(EMPTY_STRING)) { |
There was a problem hiding this comment.
would be better if we can use StringUtils.isNotEmpty(), as it would null and empty checks.
| metricAccountKey); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new IOException( | ||
| "Exception while initializing metric credentials " + e); |
There was a problem hiding this comment.
throw new IOException(message, e) would be better as the consumer of this exception can get the inner-exception.
saxenapranav
approved these changes
Jun 10, 2024
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
rakeshadr
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Thanks @anmolanmol1234 for the PR. Added a few comments, pls go through it.
| private void checkIfConfigIsSet(String configKey){ | ||
| AbfsConfiguration conf = getConfiguration(); | ||
| String value = conf.get(configKey); | ||
| Assume.assumeTrue(configKey + " config is mandatory for the test to run", |
There was a problem hiding this comment.
@anmolanmol1234 Should this be Assert.assertTrue instead of Assume.assumeTrue ?
Assume will skip the test in case of failure.
There was a problem hiding this comment.
We want to skip the tests if the config is not present hence Assume.assumeTrue
| private void checkIfConfigIsSet(String configKey){ | ||
| AbfsConfiguration conf = getConfiguration(); | ||
| String value = conf.get(configKey); | ||
| Assume.assumeTrue(configKey + " config is mandatory for the test to run", |
There was a problem hiding this comment.
@anmolanmol1234 Should this be Assert.assertTrue instead of Assume.assumeTrue ?
Assume will skip the test in case of failure.
There was a problem hiding this comment.
We want to skip the tests if the config is not present hence Assume.assumeTrue
anujmodi2021
reviewed
Oct 9, 2024
| } | ||
|
|
||
| private void checkPrerequisites(){ | ||
| checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_NAME); |
There was a problem hiding this comment.
We have a method in base class already defined for this purpose. We can use that itself assumeValidTestConfigPresent
There was a problem hiding this comment.
nit: Here also we could have used the assumeValidTestConfigPresent method
|
@anmolanmol1234 please resolve the merge conflicts and add latest test result after trunk backmerge. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
============================================================
|
Have updated the same |
anujmodi2021
approved these changes
Nov 20, 2024
| } | ||
|
|
||
| private void checkPrerequisites(){ | ||
| checkIfConfigIsSet(FS_AZURE_METRIC_ACCOUNT_NAME); |
There was a problem hiding this comment.
nit: Here also we could have used the assumeValidTestConfigPresent method
|
@anmolanmol1234 please do a 3.4 backport and trigger a test run for validation. |
anmolanmol1234
added a commit
to anmolanmol1234/hadoop
that referenced
this pull request
Jan 21, 2025
…config (apache#6847) Fixing test failures when the needed configs for metric collection are not set Contributed by: Anmol Asrani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes the test failures when the needed configs for metric collection are not set