HADOOP-19210. S3A: Speed up some slow unit tests #6907

steveloughran · 2024-06-27T12:14:48Z

HADOOP-19210

Speed up slow tests

TestS3AAWSCredentialsProvider: decrease thread pool shutdown time
TestS3AInputStreamRetry: reduce retry limit and intervals

On a test run with -Dparallel-tests -DtestsThreadCount=10 this reduces test execution time from 03:00 min to 02:26 min.

How was this patch tested?

reran old tests and measured time difference.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Speed up slow tests * TestS3AAWSCredentialsProvider: decrease thread pool shutdown time * TestS3AInputStreamRetry: reduce retry limit and intervals On a test run with -Dparallel-tests -DtestsThreadCount=10 this reduces test execution time from 03:00 min to 02:26 min. Change-Id: I87c731543a3868449309fe1cd445942182ffd00b

hadoop-yetus · 2024-06-27T13:37:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 35s		trunk passed
+1 💚	compile	0m 25s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	checkstyle	0m 22s		trunk passed
+1 💚	mvnsite	0m 26s		trunk passed
+1 💚	javadoc	0m 19s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	0m 45s		trunk passed
+1 💚	shadedclient	19m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javac	0m 20s		the patch passed
+1 💚	compile	0m 17s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	javac	0m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 12s		the patch passed
+1 💚	mvnsite	0m 19s		the patch passed
+1 💚	javadoc	0m 10s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	0m 42s		the patch passed
+1 💚	shadedclient	19m 59s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 57s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		81m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/1/artifact/out/Dockerfile
GITHUB PR	#6907
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c266f821d232 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e1049db`
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/1/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran · 2024-06-28T10:25:02Z

need some reviews here. @mukund-thakur @ahmarsuhail @HarshitGupta11 . This is for your benefit as much as mine

ahmarsuhail · 2024-06-28T10:58:08Z

...p-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java

        .assertThat(credentials.size())
        .describedAs("List of Credentials providers")
-        .isEqualTo(3);
+        .isEqualTo(TERMINATION_TIMEOUT);


why is credentials.size() equal to TERMINATION_TIMEOUT?

ooh, good catch. I pulled out the constant and must have found that as a match. will fix

Change-Id: I9c5ab2159d25b7a78d0fec64407362aec29c0374

ahmarsuhail

+1, LGTM

zeekling · 2024-06-28T13:49:14Z

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3AMockTest.java

+
+    // tight retry logic as all failures are simulated
+    final String interval = "1ms";
+    final int limit = 3;


Can this change to 2?

can do, but it's nice and fast anyway

actually, I'd rather not. because this test is shared with other mock tests and it is probably a bit less risky to cut back on all of them just to speed up one test

hadoop-yetus · 2024-06-28T14:31:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 53s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	checkstyle	0m 33s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 29s		trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 35s		trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	1m 10s		trunk passed
+1 💚	shadedclient	33m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	javac	0m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 20s		the patch passed
+1 💚	mvnsite	0m 34s		the patch passed
+1 💚	javadoc	0m 16s		the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚	spotbugs	1m 8s		the patch passed
+1 💚	shadedclient	33m 32s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 35s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		126m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/2/artifact/out/Dockerfile
GITHUB PR	#6907
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux d29494f00874 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5c3e5cf`
Default Java	Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/2/testReport/
Max. process+thread count	735 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6907/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

mukund-thakur

LGTM +1

steveloughran · 2024-07-02T10:34:03Z

FYI @saikatroy038

Speed up slow tests * TestS3AAWSCredentialsProvider: decrease thread pool shutdown time * TestS3AInputStreamRetry: reduce retry limit and intervals Contributed by Steve Loughran

github-actions bot added trunk TOOLS AWS labels Jun 27, 2024

steveloughran changed the title ~~HADOOP-19210. S3A: Slow unit tests~~ HADOOP-19210. S3A: Speed up some slow unit tests Jun 27, 2024

steveloughran mentioned this pull request Jun 27, 2024

HADOOP-19120. ApacheHttpClient adaptation in ABFS. #6633

Merged

ahmarsuhail reviewed Jun 28, 2024

View reviewed changes

HADOOP-19210. review fixes

5c3e5cf

Change-Id: I9c5ab2159d25b7a78d0fec64407362aec29c0374

ahmarsuhail approved these changes Jun 28, 2024

View reviewed changes

zeekling reviewed Jun 28, 2024

View reviewed changes

mukund-thakur approved these changes Jun 28, 2024

View reviewed changes

steveloughran merged commit c33d868 into apache:trunk Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19210. S3A: Speed up some slow unit tests #6907

HADOOP-19210. S3A: Speed up some slow unit tests #6907

Uh oh!

steveloughran commented Jun 27, 2024 •

edited

Loading

Uh oh!

hadoop-yetus commented Jun 27, 2024

Uh oh!

steveloughran commented Jun 28, 2024

Uh oh!

ahmarsuhail Jun 28, 2024

Uh oh!

steveloughran Jun 28, 2024

Uh oh!

ahmarsuhail left a comment

Uh oh!

zeekling Jun 28, 2024

Uh oh!

steveloughran Jun 28, 2024

Uh oh!

steveloughran Jun 28, 2024

Uh oh!

hadoop-yetus commented Jun 28, 2024

Uh oh!

mukund-thakur left a comment

Uh oh!

steveloughran commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HADOOP-19210. S3A: Speed up some slow unit tests #6907

HADOOP-19210. S3A: Speed up some slow unit tests #6907

Uh oh!

Conversation

steveloughran commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jun 27, 2024

Uh oh!

steveloughran commented Jun 28, 2024

Uh oh!

ahmarsuhail Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

steveloughran Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

ahmarsuhail left a comment

Choose a reason for hiding this comment

Uh oh!

zeekling Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

steveloughran Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

steveloughran Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 28, 2024

Uh oh!

mukund-thakur left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

steveloughran commented Jun 27, 2024 •

edited

Loading