Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-19216. (3.4) Upgrade Guice from 4.0 to 5.1.0 to support Java 17 #6930

Open
wants to merge 1 commit into
base: branch-3.4
Choose a base branch
from
Open

HADOOP-19216. (3.4) Upgrade Guice from 4.0 to 5.1.0 to support Java 17 #6930

wants to merge 1 commit into from
+4 −4

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jul 9, 2024 •
edited
Loading

Backport 25e28b4 (#6913) from trunk to branch-3.4

@pan3793 pan3793 mentioned this pull request Jul 9, 2024
Merged
4 tasks
@steveloughran
Copy link
Contributor

no need for me to review...it's already had the +1 vote

if yetus is happy, merge it yourself.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 14m 24s Maven dependency ordering for branch
+1 💚 mvninstall 31m 25s branch-3.4 passed
+1 💚 compile 16m 47s branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 15m 43s branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 mvnsite 20m 55s branch-3.4 passed
+1 💚 javadoc 8m 28s branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 7m 41s branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 shadedclient 48m 16s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for patch
-1 ❌ mvninstall 28m 26s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 16m 12s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 16m 12s the patch passed
+1 💚 compile 15m 33s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 15m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 14m 59s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 17s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 7m 41s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 shadedclient 49m 19s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 745m 5s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 36s The patch does not generate ASF License warnings.
1034m 56s
Reason Tests
Failed junit tests hadoop.hdfs.protocol.TestBlockListAsLongs
hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/artifact/out/Dockerfile
GITHUB PR #6930
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 8aefd7bc96f2 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 2b62ad2
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/testReport/
Max. process+thread count 3797 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member

compilation is failing:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/1/artifact/out/patch-mvninstall-root.txt

@pan3793
Copy link
Member Author

pan3793 commented Jul 10, 2024

YARN-11047 pinned Guice 4.0 for HBase 1, seems we can not upgrade Guice on branch-3.4 since HADOOP-19107 was not landed on branch-3.4

@steveloughran
Copy link
Contributor

Does this mean we need to pull forward the dropping of hbase 1 to branch-3.4? I'm personally OK with that, though it should be discussed on yarn-dev

@pan3793 pan3793 changed the title HADOOP-19216. Upgrade Guice from 4.0 to 5.1.0 to support Java 17 (#6913). Contributed by Cheng Pan. HADOOP-19216. (3.4) Upgrade Guice from 4.0 to 5.1.0 to support Java 17 Aug 30, 2024
steveloughran
steveloughran requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not merge until the hbase-2 only pr is in

@steveloughran
Copy link
Contributor

#7017 is the backport of the hbase 2 move. I've put that up but don't have the capacity to do any work on it. @pan3793 @ayushtkn if either of you could do it -that'd be wonderful

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 11s Maven dependency ordering for branch
+1 💚 mvninstall 41m 25s branch-3.4 passed
+1 💚 compile 17m 35s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 15s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 24m 5s branch-3.4 passed
+1 💚 javadoc 8m 48s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 7m 48s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 49m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for patch
-1 ❌ mvninstall 29m 27s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 16m 55s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 16m 55s the patch passed
+1 💚 compile 16m 26s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 19m 7s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 39s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 7m 52s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 50m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 734m 44s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 42s The patch does not generate ASF License warnings.
1026m 21s
Reason Tests
Failed junit tests hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload
hadoop.hdfs.protocol.TestBlockListAsLongs
hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/2/artifact/out/Dockerfile
GITHUB PR #6930
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 0974263e9cf8 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 223387e
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/2/testReport/
Max. process+thread count 3470 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pan3793
HADOOP-19216. Upgrade Guice from 4.0 to 5.1.0 to support Java 17 (apa…
309a803 
…che#6913). Contributed by Cheng Pan.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 3s Maven dependency ordering for branch
+1 💚 mvninstall 39m 4s branch-3.4 passed
+1 💚 compile 17m 51s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 11s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 mvnsite 25m 34s branch-3.4 passed
+1 💚 javadoc 8m 52s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 5s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 49m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for patch
+1 💚 mvninstall 29m 47s the patch passed
+1 💚 compile 17m 6s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 17m 6s the patch passed
+1 💚 compile 16m 43s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 19m 34s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 43s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 0s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 shadedclient 50m 58s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 735m 58s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 34s The patch does not generate ASF License warnings.
1039m 47s
Reason Tests
Failed junit tests hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/3/artifact/out/Dockerfile
GITHUB PR #6930
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 4ec4d5ffa52f 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 309a803
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/3/testReport/
Max. process+thread count 3479 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6930/3/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveloughran steveloughran steveloughran requested changes

@slfan1989 slfan1989 slfan1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pan3793 @steveloughran @hadoop-yetus @ayushtkn @slfan1989