-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19244. Pullout arch-agnostic maven javadoc plugin configurations in hadoop-common #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns in hadoop-common
LGTM. let's see what the build does |
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 1, 2024
@pan3793 Thanks for the contribution! merged into trunk branch. @steveloughran Thanks for the review! I will push it directly to branch-3.4 later. |
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
…ns in hadoop-common (apache#6970) Contributed by Cheng Pan. Reviewed-by: Steve Loughran <stevel@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
…ns in hadoop-common (apache#6970) Contributed by Cheng Pan. Reviewed-by: Steve Loughran <stevel@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19244. Pullout arch-agnostic maven javadoc plugin configurations in hadoop-common.
HADOOP-18229 excludes some classes and packages from the maven javadoc plugin, which should be arch-agnostic but was only applied to the
x86_64
profile, this PR pulls them out to apply unconditionally.How was this patch tested?
This can be verified by running
mvn install -DskipTests && mvn javadoc:javadoc
on a MacBook with Apple Silicon chip.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?