HADOOP-16928. Make javadoc work on Java 17 #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Aug 2, 2024
| * <caption>Memory usage by blocksize</caption> | ||
| * <colgroup> <col width="33%" > <col width="33%" > <col width="33%" > |
There was a problem hiding this comment.
I removed/replaced all attribute/tag that were complained by the javadoc and were removed in HTML5, this might slightly impact the final HTML style but I think it should be okay.
|
@pan3793 I will attempt to verify compatibility with JDK 17/JDK 11/JDK 8. If compatibility is confirmed, I will +1. The Hadoop-Yetus report indicates issues with blanks, checkstyle, and sputbug that need to be addressed. |
This comment was marked as outdated.
This comment was marked as outdated.
4 tasks
| @@ -185,22 +185,22 @@ | |||
| * </property> | |||
| * </code></pre> | |||
| * | |||
| * <p>When <tt>conf.get("tempdir")</tt> is called, then <tt>${<i>basedir</i>}</tt> | |||
| * <p>When <code>conf.get("tempdir")</code> is called, then <code>${<i>basedir</i>}</code> | |||
There was a problem hiding this comment.
there's also the {@code } clause, but given search and replace is easier. your PR is better
|
To reviewers: part of this PR is separated to #6975, please take a look at that first. |
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Sep 4, 2024
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
Contributed by Cheng Pan
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
Contributed by Cheng Pan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-15902 added
-html4options for javadoc on Java 11 and above, whilejavadoc -html4option has been removed since Java 13 (https://bugs.openjdk.java.net/browse/JDK-8215578).To make the javadoc work on Java 17, I must remove the
-html4and fix all errors for-html5(this is default and is the only option for Java 17javadoc)How was this patch tested?
macOS Java 17, aarch64
this works
this also works
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?