Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-17630. Avoid PacketReceiver#MAX_PACKET_SIZE Initialized to 0 #7063

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

HDFS-17630. Avoid PacketReceiver#MAX_PACKET_SIZE Initialized to 0 #7063

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cf06a6
HDFS-17630. Avoid PacketReceiver#MAX_PACKET_SIZE Initialized to 0
cxzl25 Sep 23, 2024
1e68784
fix
cxzl25 Sep 23, 2024
e4fc75c
address
cxzl25 Nov 8, 2024
6295fcb
address
cxzl25 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...dfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,10 @@ private void doRead(ReadableByteChannel ch, InputStream in)

// Sanity check the buffer size so we don't allocate too much memory
// and OOME.
int maxPacketSize = MAX_PACKET_SIZE == 0 ?
HdfsClientConfigKeys.DFS_DATA_TRANSFER_MAX_PACKET_SIZE_DEFAULT : MAX_PACKET_SIZE;
int totalLen = payloadLen + headerLen;
if (totalLen < 0 || totalLen > MAX_PACKET_SIZE) {
if (totalLen < 0 || totalLen > maxPacketSize) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we check this static final variable, MAX_PACKET_SIZE, at this runtime layer instead of the initialization ?

hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/PacketReceiver.java

Lines 80 to 85 in 9a743bd

static {
Configuration conf = new HdfsConfiguration();
MAX_PACKET_SIZE = conf.getInt(HdfsClientConfigKeys.
DFS_DATA_TRANSFER_MAX_PACKET_SIZE,
HdfsClientConfigKeys.DFS_DATA_TRANSFER_MAX_PACKET_SIZE_DEFAULT);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7063 (comment)

PacketReceiver may make nested calls when reading conf, and the static block has not yet been initialized.

	at org.apache.hadoop.hdfs.protocol.datatransfer.PacketReceiver.doRead(PacketReceiver.java:166)
	at org.apache.hadoop.hdfs.protocol.datatransfer.PacketReceiver.receiveNextPacket(PacketReceiver.java:112)

...

	at org.apache.hadoop.conf.Configuration.getInt(Configuration.java:1545)
	at org.apache.hadoop.hdfs.protocol.datatransfer.PacketReceiver.<clinit>(PacketReceiver.java:82)
	at org.apache.hadoop.hdfs.client.impl.BlockReaderRemote.<init>(BlockReaderRemote.java:101)

throw new IOException("Incorrect value for packet payload size: " +
payloadLen);
}
Expand Down
Loading