-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17659. [ARR]Router Quota supports asynchronous rpc. #7157
Conversation
…easier. (apache#6868). Contributed by Jian Zhang. Reviewed-by: hfutatzhanghb <hfutzhanghb@163.com> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…ny. (apache#6870). Contributed by Jian Zhang. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
… by Jian Zhang. Reviewed-by: hfutatzhanghb <hfutzhanghb@163.com> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
…7108). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
@Hexiaoqiao @KeeProMise Sir, please help me review this PR when you have free time, thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hfutatzhanghb Thanks for your contribution! I took a quick look and briefly left some comments.
"Failed to set quota by storage type because either" + | ||
"Failed to set quota by storage type because either " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hfutatzhanghb IMO, It is best not to modify it here. It is not very relevant to this function and will increase the pipeline time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeeProMise Thanks a lot. Have fixed.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
df6a5b6
to
ea3c4c8
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hfutatzhanghb Thanks for your contribution, the wrong UT is not related to this PR, and it runs successfully on my local. merged!
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…tributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
…. Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
Description of PR
Router Quota supports asynchronous rpc.