Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19361. RPC DeferredMetrics bugfix. #7220

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

hfutatzhanghb
Copy link
Contributor

Description of PR

In ProtobufRpcEngine2 and ProtobufRpcEngine, we should use Time.monotonicNow() to calculate duration rather than Time.Now().

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HDFS-17531 Compile Tests _
+1 💚 mvninstall 43m 45s HDFS-17531 passed
+1 💚 compile 17m 36s HDFS-17531 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 compile 16m 9s HDFS-17531 passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 checkstyle 1m 16s HDFS-17531 passed
+1 💚 mvnsite 1m 37s HDFS-17531 passed
+1 💚 javadoc 1m 16s HDFS-17531 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 53s HDFS-17531 passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 31s HDFS-17531 passed
+1 💚 shadedclient 34m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 53s the patch passed
+1 💚 compile 16m 56s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javac 16m 56s the patch passed
+1 💚 compile 15m 53s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 javac 15m 53s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 13s the patch passed
+1 💚 mvnsite 1m 37s the patch passed
+1 💚 javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 36s the patch passed
+1 💚 shadedclient 35m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 47s hadoop-common in the patch passed.
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
218m 49s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/1/artifact/out/Dockerfile
GITHUB PR #7220
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux bdced48bd267 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision HDFS-17531 / 83624ee
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/1/testReport/
Max. process+thread count 1379 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@KeeProMise KeeProMise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hfutatzhanghb LGTM, thanks for your contribution.

@KeeProMise KeeProMise merged commit be06adc into apache:HDFS-17531 Dec 10, 2024
2 of 4 checks passed
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HDFS-17531 Compile Tests _
+1 💚 mvninstall 49m 15s HDFS-17531 passed
+1 💚 compile 19m 41s HDFS-17531 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 compile 17m 48s HDFS-17531 passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 checkstyle 1m 21s HDFS-17531 passed
+1 💚 mvnsite 1m 45s HDFS-17531 passed
+1 💚 javadoc 1m 19s HDFS-17531 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 54s HDFS-17531 passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 40s HDFS-17531 passed
+1 💚 shadedclient 41m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 58s the patch passed
+1 💚 compile 18m 47s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javac 18m 47s the patch passed
+1 💚 compile 18m 14s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 javac 18m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 16s the patch passed
+1 💚 mvnsite 1m 42s the patch passed
+1 💚 javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 47s the patch passed
+1 💚 shadedclient 42m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 30s hadoop-common in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
247m 58s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/2/artifact/out/Dockerfile
GITHUB PR #7220
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 58f012548473 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision HDFS-17531 / 83624ee
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/2/testReport/
Max. process+thread count 1265 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7220/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Jan 20, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Jan 22, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>

fix check style
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Jan 22, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Feb 11, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
hfutatzhanghb added a commit to hfutatzhanghb/hadoop that referenced this pull request Feb 12, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
KeeProMise pushed a commit that referenced this pull request Feb 14, 2025
…tatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Feb 20, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Feb 20, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Feb 20, 2025
…by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants