MAPREDUCE-7421. [JDK17] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient Part1. #7358
+1,413
−1,326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
changed the title
|
💔 -1 overall
This message was automatically generated. |
slfan1989
changed the title
…nt-jobclient Part1.
slfan1989
force-pushed
the
MAPREDUCE-7421
branch
from
43a50e2 to
8aca0ee
Compare
|
💔 -1 overall
This message was automatically generated. |
…nt-jobclient Part1.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@cnauroth Could you please help review this PR? Thank you very much! The PR is for MAPREDUCE-7421: [JDK17] Upgrade JUnit 4 to 5 in hadoop-mapreduce-client-jobclient. Since it involves a large number of classes, I’ve split it into two PRs: Part 1: #7358 and Part 2: #7372. Part 1 has passed compilation successfully, but Part 2 depends on Part 1, so it will take some more time to complete. |
75 tasks
cnauroth
reviewed
Feb 10, 2025
| * @throws Exception | ||
| */ | ||
| public static void main(String[] args) throws Exception { | ||
| /*public static void main(String[] args) throws Exception { |
Contributor
There was a problem hiding this comment.
Should we keep this main entry point? I've never run it myself, but I wonder if someone else found it useful.
Contributor
Author
There was a problem hiding this comment.
Thank you for noticing this issue! I will fix it.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@cnauroth Can you help review this PR again? Thank you very much! |
cnauroth
approved these changes
Feb 12, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
+1
Thanks for following up on the feedback, @slfan1989 !
Contributor
Author
@cnauroth Thank you very much for reviewing the code! Merged into trunk. |
adideshpande
pushed a commit
to adideshpande/hadoop
that referenced
this pull request
Feb 27, 2025
…nt-jobclient Part1. (apache#7358) Co-authored-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
…nt-jobclient Part1. (apache#7358) Co-authored-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: MAPREDUCE-7421. [JDK17] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?