-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19444: ABFS: [FnsOverBlob][Tests] Add Tests For Negative Scenarios Identified for Ingress Operations #7424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Test results :HNS-OAuth-DFS[WARNING] Tests run: 174, Failures: 0, Errors: 0, Skipped: 4 ============================================================
|
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LGTM
| configuration.set(FS_AZURE_INGRESS_SERVICE_TYPE, AbfsServiceType.DFS.name()); | ||
| String blobUri = defaultUri.replace(ABFS_DFS_DOMAIN_NAME, ABFS_BLOB_DOMAIN_NAME); | ||
| intercept(InvalidConfigurationValueException.class, | ||
| "Ingress Type Cannot be DFS for Blob endpoint configured filesystem", () -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using same string at two places, it would be better to define constant in AbfsError and use it at both the places.
bhattmanish98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
|
🎊 +1 overall
This message was automatically generated. |
…rios Identified for Ingress Operations (apache#7424) Contributed by Anmol Asrani Reviewed by Manish Bhatt, Manika Joshi Signed off by Anuj Modi <anujmodi@apache.org>
…rios Identified for Ingress Operations (apache#7424) Contributed by Anmol Asrani Reviewed by Manish Bhatt, Manika Joshi Signed off by Anuj Modi <anujmodi@apache.org>
This PR covers 2 changes:-