HADOOP-13386 Upgrade avro version in Hadoop #761
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
| @@ -638,6 +638,12 @@ | |||
| <groupId>org.apache.commons</groupId> | |||
| <artifactId>commons-compress</artifactId> | |||
| <version>1.18</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
why this? Should it be a separate PR from the avro update?
| @@ -62,7 +62,7 @@ | |||
| <java.security.egd>file:///dev/urandom</java.security.egd> | |||
|
|
|||
| <!-- avro version --> | |||
| <avro.version>1.7.7</avro.version> | |||
| <avro.version>1.8.1</avro.version> | |||
There was a problem hiding this comment.
if we are going to move, move to 1.8.2
Fokko
reviewed
Jun 25, 2019
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.tukaani</groupId> | ||
| <artifactId>xz</artifactId> |
There was a problem hiding this comment.
If we upgrade to Avro 1.9.0, then xz isn't included as a dependency.
|
Based on @Fokko's input (them being an Avro author and all), I think we should upgrade to the 1.9.0 release and not need the exclusion. |
|
@KalmanJantner Gentle ping, are you still working on this? |
|
@Fokko terribly sorry but I'm afraid I cannot allocate time to work on this. Could you please reassign this task to someone who can do the necessary changes? |
|
I've rebase #1007. It compiles locally, I'll work on the failing tests. |
|
💔 -1 overall
This message was automatically generated. |
|
I don't think I need to modify/add any tests, right? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
- Reword for consistency, style, tone Author: Jagadish <jvenkatraman@linkedin.com> Reviewers: Jagadish<jagadish@apache.org> Closes apache#761 from vjagadish1989/website-reorg24
|
Now the latest avro version is 1.10.2. How it is going? |
|
Hi team, Is there any ongoing work to update the dependency to the latest clean version of Avro which is |
|
@VidhiBhansali this PR is not maintained and is now out of date. There is a JIRA open - maybe you could watch that issue instead. https://issues.apache.org/jira/browse/HADOOP-18342 - that issue is not yet prioritised |
this is a troublesome topic, one i wrote up recently and called out avro as an example Yes, we could change the Avro release version by changing a single file in one of our POMS and cutting a new release. However, this would break every single application with JARs which contained compiled classes generated buy a previous avro release. All of them. everywhere. Which means people would not touch it, which means that point releases needed to get our own CVEs fixed would not be adopted. Your concerns would go from "flagged as an issue" to "our program doesn't work" If you want to do a release with all dependencies patched you are free to do so; within a single organisation may be able to This is not a be dismissive "yes we know", more a "yes, but how can we fix it?" response. if someone was to work full time on this, it would be great. but it will be work, which is why it's been neglected until now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.