Skip to content

YARN-11827. Fix the bug of 'Removing extra containers' when autoCorrectContainerAllocation is enabled. #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

YARN-11827. Fix the bug of 'Removing extra containers' when autoCorrectContainerAllocation is enabled. #7744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...n/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,8 +692,8 @@ protected void autoCorrectContainerAllocation(List<ResourceRequest> resourceRequ
request.getCapability());
int numContainerAllocated = allocatedContainerMap.getOrDefault(containerObjectType,
Collections.emptyList()).size();
if (numContainerAllocated > 0) {
int numContainerAsk = request.getNumContainers();
int numContainerAsk = request.getNumContainers();
if (numContainerAllocated > 0 && numContainerAsk > 0) {
Copy link
Contributor

@shameersss1 shameersss1 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When AM’s AskList has its container count set to 0 , This indicates that AM no longer need any containers. Isn't it safe to RELEASE all the allocated container in that case ? (Which is what the code is doing) ?

Even if the allocated containers are set to AM, They AM may choose to not use it or release it back

int updatedContainerRequest = numContainerAsk - numContainerAllocated;
if (updatedContainerRequest < 0) {
// add an entry to extra allocated map
Expand Down