You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently , there is no retry policy If we meet IOExcetion when creating block reader to read EC file. Suppose below case (using RS-6-3-1024k):
The first 4 to 6 data blocks' datanodes are very busy at the same time, createBlockReader will timeout. This will cause read failure, we should make EC support retry mechanism to mitigate read failure.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗
mvndep
9m 6s
Maven dependency ordering for branch
+1 💚
mvninstall
37m 50s
trunk passed
+1 💚
compile
8m 37s
trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
compile
7m 38s
trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚
checkstyle
1m 37s
trunk passed
+1 💚
mvnsite
2m 21s
trunk passed
+1 💚
javadoc
2m 8s
trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
2m 27s
trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚
spotbugs
6m 21s
trunk passed
+1 💚
shadedclient
44m 10s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗
mvndep
0m 34s
Maven dependency ordering for patch
+1 💚
mvninstall
2m 3s
the patch passed
+1 💚
compile
8m 16s
the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
javac
8m 16s
the patch passed
+1 💚
compile
7m 30s
the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗
mvndep
9m 16s
Maven dependency ordering for branch
+1 💚
mvninstall
37m 34s
trunk passed
+1 💚
compile
8m 17s
trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
compile
7m 29s
trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚
checkstyle
1m 32s
trunk passed
+1 💚
mvnsite
2m 19s
trunk passed
+1 💚
javadoc
2m 7s
trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
2m 27s
trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚
spotbugs
6m 17s
trunk passed
+1 💚
shadedclient
44m 40s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗
mvndep
0m 33s
Maven dependency ordering for patch
+1 💚
mvninstall
2m 4s
the patch passed
+1 💚
compile
8m 2s
the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚
javac
8m 2s
the patch passed
+1 💚
compile
7m 33s
the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17801.
Currently , there is no retry policy If we meet IOExcetion when creating block reader to read EC file. Suppose below case (using RS-6-3-1024k):
The first 4 to 6 data blocks' datanodes are very busy at the same time, createBlockReader will timeout. This will cause read failure, we should make EC support retry mechanism to mitigate read failure.
How was this patch tested?
Add an unit test to reproduce.