-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19627. S3A: testIfMatchOverwriteWithOutdatedEtag() fails when not using SSE-KMS #7816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steveloughran
merged 1 commit into
apache:trunk
from
ahmarsuhail:HADOOP-19627-if-match-fix
Jul 24, 2025
Merged
HADOOP-19627. S3A: testIfMatchOverwriteWithOutdatedEtag() fails when not using SSE-KMS #7816
steveloughran
merged 1 commit into
apache:trunk
from
ahmarsuhail:HADOOP-19627-if-match-fix
Jul 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@steveloughran @mukund-thakur small one to fix a test failure I noticed. |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
approved these changes
Jul 21, 2025
Contributor
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Contributor
|
approved, do use that updated title though; backport as required. |
ahmarsuhail
added a commit
that referenced
this pull request
Jul 30, 2025
…not using SSE-KMS #7816 Contributed by: Ahmar Suhail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We were previously creating second file with the same object content, so the etag will always be the same, leading to test failures, except when testing with an encryption method set, as in that case eTag is no longer the md5.
How was this patch tested?
Can't test on trunk as the all tests in this class fail due to the Junit5 migration. Tested on 3.4 with and without SSE-KMS, all good.