HADOOP-19635. ABFS: Marker creation failure should not be propagated #7825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
============================================================
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Blob File System (ABFS) implementation to prevent marker creation failures from being propagated to users. Marker creation is a best-effort operation that writes 0-byte files to indicate folder presence, but failures in this operation should not cause the primary operation to fail.
- Wrapped marker creation calls in try-catch blocks to catch
AbfsRestOperationException - Added debug logging when marker creation fails instead of propagating the exception
- Added a test to verify that
getPathStatusoperations complete successfully even when marker creation fails
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| AbfsBlobClient.java | Added exception handling around marker creation in setPathProperties and getPathStatus methods |
| ITestAzureBlobFileSystemOauth.java | Added test case to verify marker creation failures don't propagate during getPathStatus operations |
...-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java
Outdated
Show resolved
Hide resolved
...-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java
Outdated
Show resolved
Hide resolved
.../hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
Outdated
Show resolved
Hide resolved
| this.createPathRestOp(path, false, false, false, null, | ||
| contextEncryptionAdapter, tracingContext); | ||
| try { | ||
| this.createPathRestOp(path, false, false, false, null, |
Contributor
There was a problem hiding this comment.
Test case to check this change is not added, should we add that?
Contributor
Author
There was a problem hiding this comment.
This change is no longer needed
| this.createPathRestOp(path, false, false, false, null, | ||
| contextEncryptionAdapter, tracingContext); | ||
| } catch (AbfsRestOperationException exception) { | ||
| LOG.debug("Marker creation failed for path {} during setPathProperties", path); |
Contributor
There was a problem hiding this comment.
It would be better we can log exception status code as well or some details of exception just to know what the exact reason of the failure is
Contributor
There was a problem hiding this comment.
+1 on this.
At least status code and storage error code (Enum like PATHNOTFOUND) we should print in debug log.
Also a comment here on why we are swallowing the error for future reference will be better.
| this.createMarkerAtPath(path, null, contextEncryptionAdapter, | ||
| tracingContext); | ||
| } catch (AbfsRestOperationException exception) { | ||
| LOG.debug("Marker creation failed for path {} during getPathStatus ", path); |
| this.createPathRestOp(path, false, false, false, null, | ||
| contextEncryptionAdapter, tracingContext); | ||
| } catch (AbfsRestOperationException exception) { | ||
| LOG.debug("Marker creation failed for path {} during setPathProperties", path); |
Contributor
There was a problem hiding this comment.
+1 on this.
At least status code and storage error code (Enum like PATHNOTFOUND) we should print in debug log.
Also a comment here on why we are swallowing the error for future reference will be better.
| try { | ||
| this.createMarkerAtPath(path, null, contextEncryptionAdapter, | ||
| tracingContext); | ||
| } catch (AbfsRestOperationException exception) { |
Contributor
There was a problem hiding this comment.
Was keeping this behind a config not part of the plan?
Contributor
Author
There was a problem hiding this comment.
No we planned to just swallow exceptions instead of config changes
manika137
reviewed
Jul 28, 2025
| // Implicit path found. | ||
| // Create a marker blob at this path. | ||
| this.createMarkerAtPath(path, null, contextEncryptionAdapter, tracingContext); | ||
| try { |
Contributor
There was a problem hiding this comment.
For confirmation- we want to swallow exceptions only for metadata related operations and allow permission exceptions for all write ones (createDirectory, createFile), correct?
Contributor
Author
There was a problem hiding this comment.
marker creation is best effort for us, we don't want to fail the actual operation called if marker creation fails, so only for marker creation we are swallowing exception and not blocking the actual call
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
manika137
reviewed
Jul 29, 2025
| * */ | ||
| @Test | ||
| public void testGetPathStatusWithReader() throws Exception { | ||
| String clientId = this.getConfiguration().get(TestConfigurationKeys.FS_AZURE_BLOB_DATA_READER_CLIENT_ID); |
Contributor
There was a problem hiding this comment.
Nit: since we have already imported TestConfigurationKeys constants we can use FS_AZURE_BLOB_DATA_READER_CLIENT_ID and FS_AZURE_BLOB_DATA_READER_CLIENT_SECRET directly
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
manika137
approved these changes
Jul 31, 2025
anmolanmol1234
added a commit
to anmolanmol1234/hadoop
that referenced
this pull request
Sep 3, 2025
…pache#7825) Contributed by Anmol Asrani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marker creation is a best-effort operation performed during folder-related actions such as create, getPathStatus, setPathProperties, and rename. It involves writing a 0-byte file to indicate the presence of a folder. However, marker creation is not critical to the success of the primary operation. This change ensures that failures encountered during marker creation (e.g., due to transient issues or permission errors) are not propagated back to the user, preserving expected behavior and preventing unnecessary operation failures.