HADOOP-19617 - [JDK17] Remove JUnit4 Dependency - HuaWeiCloud. #7871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the HuaWeiCloud module by removing the JUnit4 dependency and migrating to AssertJ for test assertions. This is part of a broader effort to remove JUnit4 dependencies in preparation for JDK17 compatibility.
- Replaces JUnit4's
Assume.assumeTrue()with AssertJ'sassumeThat()in test files - Removes JUnit4 dependency from pom.xml and adds AssertJ dependency
- Updates test assumption syntax to use fluent AssertJ API
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| TestOBSContractRename.java | Migrates test assumptions from JUnit4 to AssertJ |
| TestOBSContractCreate.java | Migrates test assumptions from JUnit4 to AssertJ |
| pom.xml | Removes JUnit4 dependency and adds AssertJ dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public void testCreatedFileIsVisibleOnFlush() { | ||
| Assume.assumeTrue("unsupport", false); | ||
| assumeThat(false) | ||
| .as("unsupport.") |
There was a problem hiding this comment.
The error message contains a spelling error. 'unsupport' should be 'unsupported' to match standard English.
| public void testRenameFileUnderFile() { | ||
| Assume.assumeTrue("unsupport.", false); | ||
| assumeThat(false) | ||
| .as("unsupport.") |
There was a problem hiding this comment.
The error message contains a spelling error. 'unsupport' should be 'unsupported' to match standard English.
| public void testRenameFileUnderFile() { | ||
| Assume.assumeTrue("unsupport.", false); | ||
| assumeThat(false) | ||
| .as("unsupport.") |
There was a problem hiding this comment.
The error message contains a spelling error. 'unsupport' should be 'unsupported' to match standard English.
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@cnauroth Could you please review this PR? Thank you very much！ |
cnauroth
reviewed
Aug 16, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
Should these tests use the JUnit5 @Disabled annotation instead of "assume false is true?"
Contributor
Author
@cnauroth Thank you for reviewing the code! Your suggestions are very reasonable, and I will optimize the code based on your feedback. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
requested changes
Aug 17, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
Thanks for the update, @slfan1989 . I think the @Disabled annotation needs to go on just these individual test methods, not at class level. Otherwise, it will skip numerous other base class tests (which I assume are passing).
Contributor
Author
@cnauroth That’s a good suggestion, and I think it makes sense. I’ll keep working on improving this part of the code. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
force-pushed
the
HADOOP-19617-Cloud2
branch
from
8d518d8 to
cb8a795
Compare
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
approved these changes
Aug 18, 2025
| </dependency> | ||
| <dependency> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> |
Contributor
There was a problem hiding this comment.
I think this dependency was used in the first version of the patch, but not in the current version. If so, can you please remove this dependency before committing?
Otheriwse, +1. Thanks @slfan1989 !
Contributor
Author
There was a problem hiding this comment.
@cnauroth Thank you for your suggestion! I agree with your point and will remove this dependency.
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
approved these changes
Aug 19, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
+1. Thanks for incorporating all of the feedback, @slfan1989 !
Contributor
Author
@cnauroth Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19617 - [JDK17] Remove JUnit4 Dependency - HuaWeiCloud.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?