HADOOP-19650. [ABFS] Fixing NPE when close() called on uninitialized filesystem #7880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
anujmodi2021
changed the title
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
approved these changes
Aug 18, 2025
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
+1 pending a small change to the javadocs around isClosed
| private Path workingDir; | ||
| private AzureBlobFileSystemStore abfsStore; | ||
| private boolean isClosed; | ||
| private boolean isClosed = true; |
Contributor
There was a problem hiding this comment.
so this really means inited and closed. Mention that in javadocs.
Contributor
Author
There was a problem hiding this comment.
Yes, added the javadcoc.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
:::: AGGREGATED TEST RESULT :::: ============================================================
|
| @Override | ||
| public synchronized void close() throws IOException { | ||
| if (isClosed) { | ||
| if (isClosed()) { |
Contributor
There was a problem hiding this comment.
Should we throw an exception in case someone is trying to close non initialized or already closed file system?
Contributor
Author
There was a problem hiding this comment.
fs.close() is supposed to be idempotent IMO
Contributor
There was a problem hiding this comment.
There is chance that more two threads can attempt to close store and client which can cause similar issue what we got now.
Contributor
There was a problem hiding this comment.
@bhattmanish98 I don't see concurrency issues because close() is synchronized, and once closed it can't be closed again. Of course, once one thread has closed it, nobody else can use the instance. fix: don't do that.
Contributor
There was a problem hiding this comment.
@steveloughran Make sense, I overlooked synchronized in the method definition. PR Looks good. Approved the changes.
manika137
approved these changes
Aug 20, 2025
| () -> fs.makeQualified(testPath)); | ||
|
|
||
| intercept(IllegalStateException.class, ERR_INVALID_ABFS_STATE, | ||
| () -> fs.setOwner(testPath, "", "")); |
Contributor
There was a problem hiding this comment.
EMPTY_STRING can be used here
Contributor
Author
There was a problem hiding this comment.
Will take up this.
|
💔 -1 overall
This message was automatically generated. |
anmolanmol1234
approved these changes
Aug 20, 2025
|
🎊 +1 overall
This message was automatically generated. |
bhattmanish98
approved these changes
Aug 20, 2025
bhattmanish98
suggested changes
Aug 20, 2025
Contributor
bhattmanish98
left a comment
bhattmanish98
left a comment
There was a problem hiding this comment.
Please check the added comment.
steveloughran
approved these changes
Aug 20, 2025
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
+1
ready to merge.
| @Override | ||
| public synchronized void close() throws IOException { | ||
| if (isClosed) { | ||
| if (isClosed()) { |
Contributor
There was a problem hiding this comment.
@bhattmanish98 I don't see concurrency issues because close() is synchronized, and once closed it can't be closed again. Of course, once one thread has closed it, nobody else can use the instance. fix: don't do that.
bhattmanish98
approved these changes
Aug 20, 2025
Contributor
Author
Sure, just did a commit to rerun yetus, will merge as soon as green. |
|
🎊 +1 overall
This message was automatically generated. |
anujmodi2021
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
Aug 20, 2025
…AzureBlobFileSystem (apache#7880) Contributed by Anuj Modi
anujmodi2021
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
Aug 20, 2025
…AzureBlobFileSystem (apache#7880) Contributed by Anuj Modi
anujmodi2021
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
Aug 20, 2025
…AzureBlobFileSystem (apache#7880) Contributed by Anuj Modi
Contributor
Author
|
Will do backport for 3.4 and 3.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
AzureBlobFileSystem.close() throws NPE when called before initialize().
Before initialize, store is null.
Fix is to avoid calling any stor method before initialize is complete.
How was this patch tested?
New test added and existing tests were run.