-
Notifications
You must be signed in to change notification settings - Fork 9.2k
WIP. Provide hadoop dev contianer Dockerfile for riscv64 #7924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
f37e917 to
2a46d9c
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@pan3793 From my personal -1, please do not add such mirrors as there is no dedicated personnel for maintenance, and this has already been discussed. |
|
can we at least do the protobuf move; I will start a thirdparty release |
I respect Steve’s opinion on this PR. If he gives a +1, I’ll also add my +1. |
|
@pan3793 Sorry, I won't be able to follow up on the riscv64 review because I am not familiar with riscv64. I have clearly stated that I do not plan to introduce other versions of the image into the trunk branch. cc: @steveloughran |
|
@slfan1989, I understand your concerns. To clarify:
|
Description of PR
I saw that some contributors have started adding riscv64 support. Currently, Hadoop neither has riscv64 CI pipeline nor a dev container, the reviewers are not easy to verify the patch on x86_64 or aarch64 platforms.
This PR proposes to leverage Docker's cross-platform capability to allow running standard dev containers on x86_64 or aarch64 platforms.
How was this patch tested?
I'm using a MacBook Pro with an M1 Max chip.
Launch Hadoop dev container
Successfully building hadoop common modules, there are some issues that need to be fixed independently
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?