HADOOP-19733. S3A: load credentials providers using configured classloader #8048
+86
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lassloader Follow-up to HADOOP-17372 and HADOOP-18993. The issue described in HADOOP-18993 still existed, because the code path to load credentials providers goes through `S3AUtils#getInstanceFromReflection` and always uses the classloader that loaded the `S3AUtils` class. With this change, credentials providers are loaded using the Configuration's classloader so they respect the user's `fs.s3a.classloader.isolation` setting
brandonvin
commented
Oct 23, 2025
...hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Oct 23, 2025
There was a problem hiding this comment.
looks good and it's nice to have that spark test done.
Here's the full policy on testing though:
https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/testing.html#Policy_for_submitting_patches_which_affect_the_hadoop-aws_module.
you are going to have to run all the integration test suites against an s3 store and say which one (S3 london) as well as the maven parameters for the hadoop-aws module, such as -Dparallel-tests -DtestsThreadCount=8 -Panalytics
regarding mapof() versus Map.of(); it's best to leave as is for backporting
| import org.apache.hadoop.fs.FileSystem; | ||
| import org.apache.hadoop.fs.s3a.impl.InstantiationIOException; | ||
|
|
||
| import software.amazon.awssdk.auth.credentials.AwsCredentials; |
There was a problem hiding this comment.
nit: put the amazon imports in the same group as the junit ones
...hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java
Show resolved
Hide resolved
...hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java
Show resolved
Hide resolved
...hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java
Show resolved
Hide resolved
| private final ClassLoader customClassLoader = new CustomClassLoader(); | ||
| private final ClassLoader customClassLoader = spy(new CustomClassLoader()); | ||
| { | ||
| try { |
There was a problem hiding this comment.
this is a nice way to simulate classloader pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Follow-up to HADOOP-18993 and HADOOP-19733 before it.
With
fs.s3a.classloader.isolationset tofalsein a Spark application, it was still impossible to load a credentials provider class from the Spark application jar.fs.s3a.classloader.isolationworks by saving a reference to the intended classloader in theConfiguration.However, loading credentials providers goes through
S3AUtils#getInstanceFromReflection, which always used the classloader that loadedS3AUtils. It should useConfiguration's classloader.How was this patch tested?
Unit tests in
org.apache.hadoop.fs.s3a.ITestS3AFileSystemIsolatedClassloader.Manual testing in a Spark application.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?