YARN-11883 TestResources class inconsistent clean up addressed #8049
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
TestResources class has indeterminism because state is not cleaned between test.
These particular tests are affected:
org.apache.hadoop.yarn.util.resource.TestResources.testAdd
org.apache.hadoop.yarn.util.resource.TestResources.testClone
org.apache.hadoop.yarn.util.resource.TestResources.testCompareToWithNoneResource
org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMax
org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMin
org.apache.hadoop.yarn.util.resource.TestResources.testFitsIn
org.apache.hadoop.yarn.util.resource.TestResources.testMultiply
org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundDown
org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundUpCustomResources
org.apache.hadoop.yarn.util.resource.TestResources.testSubtract
org.apache.hadoop.yarn.util.resource.TestResourceUtils.testGetResourceTypes
Problem
Although the test class
TestResourceshas set up clean up methods to clean up the shared resourcesresourceFile, it is not called before and after every test. This leads to pollution of shared state.Fix
This can be addressed by consistently calling existing clean up functions after every test. The clean up functions were added to the
setup()andteardown()functions to ensure they are called consistentlyHow was this patch tested?
All existing unit tests for the class passed and continue to pass after the change.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?