Hadoop-19735. ABFS: Adding request priority for prefetches #8050
+133
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
|
||
| if (getAbfsConfiguration().isEnablePrefetchRequestPriority() | ||
| && ReadType.PREFETCH_READ.equals(tracingContext.getReadType())) { | ||
| requestHeaders.add(new AbfsHttpHeader("x-ms-request-priority", "7")); |
There was a problem hiding this comment.
Both values should come from constants
There was a problem hiding this comment.
Also, the priority value 7 can be changed tomorrow, so we should keep it configurable.
|
|
||
| if (getAbfsConfiguration().isEnablePrefetchRequestPriority() | ||
| && ReadType.PREFETCH_READ.equals(tracingContext.getReadType())) { | ||
| requestHeaders.add(new AbfsHttpHeader("x-ms-request-priority", "7")); |
|
💔 -1 overall
This message was automatically generated. |
| * Enable or disable request priority for prefetch requests | ||
| * Value: {@value}. | ||
| */ | ||
| public static final String FS_AZURE_ENABLE_REQUEST_PRIORITY_FOR_PREFETCH = "fs.azure.enable.prefetch.request.priority"; |
There was a problem hiding this comment.
Rename the variable to FS_AZURE_ENABLE_PREFETCH_REQUEST_PRIORITY.
|
|
||
| public static final boolean DEFAULT_FS_AZURE_ENABLE_CREATE_BLOB_IDEMPOTENCY = true; | ||
|
|
||
| public static final boolean DEFAULT_FS_AZURE_ENABLE_PREFETCH_REQUEST_PRIORITY = false; |
There was a problem hiding this comment.
Are we not enabling this feature by default?
|
|
||
| if (getAbfsConfiguration().isEnablePrefetchRequestPriority() | ||
| && ReadType.PREFETCH_READ.equals(tracingContext.getReadType())) { | ||
| requestHeaders.add(new AbfsHttpHeader("x-ms-request-priority", "7")); |
There was a problem hiding this comment.
Also, the priority value 7 can be changed tomorrow, so we should keep it configurable.
|
|
||
| final AbfsUriQueryBuilder abfsUriQueryBuilder = createDefaultUriQueryBuilder(); | ||
|
|
||
| if (getAbfsConfiguration().isEnablePrefetchRequestPriority() |
There was a problem hiding this comment.
This part of code is common for both DFS and Blob client, we should put this logic in a method and put it in AbfsClient class.
| op = client.read(path, position, b, offset, length, | ||
| tolerateOobAppends ? "*" : eTag, cachedSasToken.get(), | ||
| contextEncryptionAdapter, tracingContext); | ||
| contextEncryptionAdapter, new TracingContext(tracingContext)); |
There was a problem hiding this comment.
Why this change is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19735
Adding low traffic request priority (behind a config flag) for prefetches to reduce load on server during throttling
How was this patch tested?
Test suite will be run